Skip to content

Fix Ancestrally Boosted Strikes incorrectly having a base More Damage Multiplier - #2370

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
Peechey:fix/ancestral-call-strike-more-damage
Aug 30, 2026
Merged

Fix Ancestrally Boosted Strikes incorrectly having a base More Damage Multiplier#2370
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
Peechey:fix/ancestral-call-strike-more-damage

Conversation

@Peechey

@Peechey Peechey commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #2369

Description of the problem being solved:

Ancestrally Boosted Strikes do not have a damage multiplier like AB Slams, but the function I wrote for the ancestral boost logic uses a multi of 1 if no damage multiplier is provided, which was the case for Ancestral Call. Probably a leftover from many iterations of that Ancestral Boost PR. I'm simplifying the combined function because we can use the MoreDamageMulti directly and don't need to pass it in for every call. AB Strikes will have a 0 MoreDamageMulti as the BaseConfig for that field requires SkillType of Slam.

Steps taken to verify a working solution:

  • Validate Ancestrally Boosted Strikes by themselves have no more damage component
  • Validate Ancestrally Boosted Strikes still have added Strike Targets
  • Validate Ancestrally Boosted Attacks and Empowered Attack passive skills still applied
  • Validate Slam damage numbers in Live vs PR

Link to a build that showcases this PR:

eNqtW1tPIzsSfh5-RSvSSrs6GnKBcBPMUUhgiJZLNmFmdp9GpttJvLjbmbY7kHN0_vtW2e5LAknssDMSuN31VdlV5XK52pz__hrzYE5TyURyUWvuN2oBTUIRsWRyUfv2eP35pPb7l73zAVHTh_Flxji-aX3Z-3SuHwIiQ5pEXU6kvCcxvajdi4TWAk7nlAO_WjBn9OVORPCmfzd4GD7WAkXSCVXfc5mNn0AVTklKQkXTWwR2MiUMRqUZcIsJS0YifKbqayqymeYbliKHJJnQtAaD-nQ-4GRB05EiKpDw46LWgcmRCe2RGH7CcAjPANJsHe63j1tHp-3G8UGrWatvBF9mqVS7cRjNKI1K0H6jvY5ykNKr8ZiGis1pN2WqOyVJWJHXWAf0Jr7LuGIzzkBnOaC1jv7mHd5rmT8KRXhvMCppDxr7J43mQev0pHV0crwZJ1SBa2yjrApZP9eMc_DWKu3Rfrt9dNg-PjpoH26w2pBKms6JAgd1kyTiJ5bQqDOf-DrIHUlIV8hy7u3GJtIBTWHBqSXENsCIhgLW6JKQ1n7bQcz74LXybtmYulN6TcUCfEez2zyuRq503ox3G9AQIo8b5Uhk3JFSlcv_eP1C-FWlW-szPfpaOn57A7clwtZauf1EOQ2uSndytH50c4Fr2SG-pOwpU9QxEF3dDErVtPdbzebxafvo4ODgcH2Uny4kCwm_I68szmIIr4_kmZYjO2qvd-fJVCUQz9ZBDw_WQa9ZSv1RXcGjHVBTIqT_7O5gi78hSdQJwwwygUUBOV1rgh5JnxMqpcPy0eGcRu4IjB0Oo4bdPTxD2n4Sbl8kSPgtSe1gnEw-pkMIE5iFPHHqiChF2GDjsnUbUROaWHkLNx3dUhpOv4LtQBRY221LctjqtGKRtqrYjUzfUWzbEeChJgS-r6bWJoi3mkYzljKnERnKd2bvgfFQwFVC08liNGWURw77XYU611iXzFzmD_avop38YFmclzNXod7Wwu3ZV96cyOqOdLxZE4baTQlzEtGVnH29P1NOqRdikIr_4iGF-8FgGpz7I3aU1qNjjjCRDCGJTybOCFcBnTQWWerox4bYyXh5emAOm0MaZaFb4lIcHS85HJRXj2wnW2Fa2-9h16tAKRI-90Q08TOpF2J5fKNsNoOYhUvBlQGmPrD9s0pG_LntQP0Ay9gpUmGW5C6gpHYWUOR97lJWIO5zwdxtRYwLsbOAwpx3ECZj2HJ0eeROVHatDeURScHkQxKxTN5RBc9lOrrWoBnnTid4TehYVxiIF5jvFMtY0o8a8uICsD5bT2nyx8KZ_xK5k4CrJIIcG3TpLGMV8Z6Yy2w8lkEo4ieibsEpLmq14An68jbk9ZLaB4N4ZDFsP1L2iCJBZM9o30nKSKKausi30tnSnZKSNJzmbMuna8L5E4Qky_-8riuU2OqKZMwmATG1Nf0wogqZ6XEUPQGL8k6thJBOYb3SNEh0nZEmNF70QJIJPUkWP9EUMj-rtvcgcVFq6zHwfTCV-go_YCvDUBOVTJrreUQ0Fsm1SOMRBlxZwWwQrMdaDX45qL0BhAUJhvruijTNZrhzdtMFiNVO4iwWa4x5tTQHHWwDFTFrgOfFArYFZcurOflxw8kWP5iagi0irdCuyCAOUT6uzLDtwmWksiShmNeCVfnCyZbv-EMnjoW7MxgfNNmB4FyXvqvzd5o-rJh08U16jl2LLvLWAtA83qAtySaMP4x1DHzjR9vcCHpW3ej0qO2A8nKhN_ury0oZTSFTerMeHZaj_4QQ5TWh5RzSS3fV_T-HNVxAb5Z7XozbGCRwlD8o0TWZVWW6RdVuluIaWj6VloFq29jzND5HnDSONmh3FArYajys3p0ySFo9vaSaULq4onFi_GxWmUfL1el3cJLK56ZifHZHrxdbqd6AzRM2H1NKvzP6EvwhRHxrPg4e1PTTf9DFdOvfuiWn4gVTjzxAhlTm3wHNXj9Sab7F9-OZSFVAX_HXgKRqcVEbEy6ped0lPJR6YP1klqnce5gMf2Jmgp8YgalK9cfOq-vrq-5j__uVnUsVIp_BkD_NbN9Y8nxkjpqBzJ6kaV7UcLIjRPWoIoyD_TG30D2w1wAVJEQQv8kMonB1zO9z07ibcldFXpVHD05XoLEXu_cpOyq9HzAMzb5DMgPAkgfmcoab_o7nwcicI7tEKjirWx52W_fggl5pp9PVlTMPLHgR4VZy3vbVhFrMqITDPhuzsKJa_e4R3tk-H70UlXBr7XzRefC45FqPyMA2PcADwSTu9IjO2z5anSQst2fe9oD3aEjs3G3TA1xU8ESiC3jIpejz4nQvEu3kECI6jOOR1Vr2itOyw4PhA6ae5hxsOd1BPCo6_BaO-Vpl-VSffXSlP3VoDemWB9QU8_UcdMtn0dgCt1ntzHfJLm_42h5LPR6szF5rdZhvvD5msDmENoFt-8wkT6j1JPIHn4WiY3BnLlhk4oNeMqudXkEDctuPs9F1vv8Dm6KU-3Fe15zIZ2vpvO0B_6YYZ2qxhYtOVTYvt49xwLX2MQ5YxYl3Rg-LFGS4mn04yJ3k4ap4cMcXZaidOZhi2c5wfY7dGa1DP_izzmnL2F_2-MRPlSU9UEa5MHZmpYe1Ej_WMnOZot0XHWe6haNZ7_YaQRkAbIdvnIRt_KZIFHflVFSxbyjhajoQgn-M4ZvrEh9hht8gsxlJopzdw3J6vobtNjMIJYGnLqn28FPnR3Wo61gOjIpxwXHSHufO7wUkOcgae_OHc33-CyIqFUuI3Zs5WGYEB8pONEfnfgRTyXxwAZnNaLI0Vn1OtXVi_HRXlIjxwVw57Uf4rT9QeKAtr7C2a_YmLEhZ9BNF04RwJIXTIpwyJR7hD9un9tpqlaBVq96hxR48A-u7YSRddJZfJYzjbVgJ8IVNGUGEOa5_G97qxqepUjN5Vq-_vLzsz4iaijF9ZZzuhyKuz4ARzO2zPtB-xknUO_DvctLHXx3NqJ5zOjd3bqWtB6AfpSwymofnIt_MXwQsUfdmtvpYXbQj-pq3La_6ErPzOupX2xgNoE_2isbSWgLbtl4fZJKai3M_KJmJRHdrrawvG5jTPPColveHBFLOxVkw7Ayv9u7pS4AEex06YTL4VwaeBLZVZDze66ZkrGh0FiCvvUFKx-z1LMBbzhseRtnY5QEEcT2KVmPP6vosGJn_e8MsoZZua1NXVIb011lwfLoHR1jOQoa8mnt_KjKRZ0-Y0v31Z4rV4rPmX7_9vdn63Dz5x98CJQKd7uEFbFCZts2diHRZ2aor0Kiy2lFHTRU6xa8miilOdaZGMm5z-g2msr7FhQrgUBgPnsDf9ELRpRZDHDSD0Qt-UUQKsyjqTriWL-6WToKWJ33Tgx6OBF78kd6Hv87fvCQYhI8MnS8GB_7WqAhpbp14nHGqPGTcUEgz1A4u4gG5FNEiKE54rqivXMx13uMuRigf-iHkMV4W1ICWt8n9ET6DuqRc-c7hrROagJSXnPW-gS1deZOw9eig9JXmVedEpHFx_Ra2DZHiS3m56A1G11g8KG_z68sASwR5IdpmCKaaazYm3H8gNpBwgdRFjlHKt8G-rHFns5nhjfVBQHRub22yYfkufY7WnbDDhjyLaD-xFxuKlIAlnXJMekArfTp50i84eUJF4B_64K3SqLJNghwYj30BXvxEeDOfMxrB5ET_ZPrvKoIB4fEqF0jdssRoxP4NUKuBnfp7sjVB2VFmisHEGPWOKhIRRYwh66jLuh4_tKzcqlgzxlYufG7uCSCjJeJfVd0jtxUKc-HBOqCTDjqYYKiU8AAUy4N-f7simh_TQ710mEI4yn58Edu1sYSwjDTwXc1YgiWQURFi8hROm8Wmb9Zj9RI0K-_L3nn9zV-N_Q92MLEP
eNrtHNly4zbyefQVLFWlKlNjWzx0uuRsyfIh7fpQJHsm2ZcUTEIS1xShIUF7lFT-fbsBkiJ1grKTyh7z4CHB7kajLzQagNp_-zbztBcahC7zz8rGiV7WqG8zx_UnZ-XHh6vjZvlvP5TaA8Kn9-PzyPXwi_lD6UNbvGgvLn29ZQ49K_dvB_fDh7Lm0RfqnZVNoGRPSUBsToMbbOtEnElQHkS0rJHQpr7T9UgY3pEZND-4nPhlbUZcf8TsZ8qvAxbNgRRQWkJ9IUHgsqCscRJMKP-c8K7_YpSBrw_tgUcWNBhxwrUX4kWAUtWb9ZOqpTetegOey1oIH8_KHRg3mdALMoO_5cpByOdREPI9FPSTxhJvNKfU2QraOKkmgIOAXo7H1ObuC-0GLu9OiW9TFUwFaDMLext53J17Lg22whu6nmD09hNvtqwTo2Xpllk1zFqC-MA48S4Go-1yykMyXrSHLy6fnnsg3129GHrrxGw2mqZRr9VSmfUnvsvpLjxL182TalNv1qp6vdHK9rkfeQfDA-aGzC_OcSIkJYl2I88Dx1WCHdKQBi-Eu7u52iKPLps9uf4eFRip_d0Sn3RZyPezhZADGkDM4DsRGiCsVn0Fa0RtBrGmaEcFMW_cMVWHVBnMKkJRbg4bx-VIFa4w4cMYGkJ4VYMcscjbbR6p8434jnhXt5bu8HUXZCOBu6DftpOrNTLkdkGmcH1_-xhqGWK74PQlby8M_Vkh9AbuU8S3x3bLsk5ahmnWLFM39VYuGF32Bttn0Wo6Aw6mi9C1iXdLvrmzaAbzyQN5ptt5M1vNpUlPptyHQHYA7pUb0APQusxzVNGq1VR9MEWyULm7emMZfFy_R3ynY9sR5E4LBd2S4NmnYaga2CE078PIjAODyH47hKTGPkXQvm-rUn30g5gfVYwhRAzMup48qpKo5DuJA49a2BzSCfXj7hZqKDeU2tNr0N6Q7HAfw8pNMwrxDCWLoLsku0JVQbIZMeUx9ompdpKbugsKClEUBaVnROBCkqoOWWz4qzjKdnLp02CyGE1d6jnFoBN5dclc0QCy2LsMYUt3hXSURVXTVW6aVust9evLFxIqTUxSDhJ6py9kKDt0z0olBb6lsGwohDEI2L9wceYVQ4NheF5xjGK9Zeb9sYdoDBUI06Yyxr4VXgrfCWYsChTVJ4F3zhGrSYJcWg-pE9lqCUy6Zj73mP2sKqgUS0i7EGqHc2I_XzBnoqwW0UkhjDx_o2g-h3iFrrCHwHFNz-Y_kAG4Kln0EvYe3HhXnMp0gJmSagdL2AIdpNmfai8rCPu60nPJm_JQlsD7OjDW1HkLYXIG042oCt0yR8ExcKIClQ-J40bhLeXwrqBQWP8rLf4FoGJRYcBeYbxTLMNtZ8HaBA2JsQIrAfV_XSjTz4ErdXDpO5BjgyyV-1jFWHZzHo3HoWaz2RPhN2AKZ-Wy9gRt8rnvj2ngE0_rwpyoQWYf0hhIYj-4M5iAwvCCcKKFlAT2NCGyfLsinvcEoUa0ivroletxGlzAN-RJjMyJV3qfSeASnxvC6FYaTWzEjtsVUcTFp4eAUo0kIcZGCMEZvmQrtX1HUASro5nKaxWrtiHwspCWHSKPEgs4W8AaVQwfkePyLdDwmUMB0KrXzdaRVavWrCOjaeqNIwtWl9Uj07CajSNYGpm1o6ppNuBvw4C_VrNerR_Vqq1W66jWaOjWUc1qGPDcajQa0G5aJvxtGsZR1dAtA54N_ahqwZPV1I3qUb3a0vUjS2809aO6ZUCLadUaAFKt11pHRrUGmIboFda4dXhuiHKVqEBnB1JP2hxZThXlDBIsOnlh-a4nJPmh_Ti8EQ8fppzPw9NK5fX19WRO-JSN6TeY2U_AeipzQAMdHIfPrucdo5grHfh3PumfX7PmZ9c3ej3j_oZcf_H6tSfT4OPpP1u9n-o_9x7Mu5-f2KX9uT-9CLxeozXtTZotNrcvv9Z-vf9H6_yz07n7kU-A2tmZYKiScNSW5fawIt8wjAUuKEey24YZTlYFkg-a6_M7qT00rm_pc8iDu6xWpTakHqR8paylfqT0szqM5S40KfRfjlmq5HhqV9AshQGj3eLDCOUVAjNjEnn8ms5u5DaEz4JZWmoABqfsFWdPFiDMw2KOvHZubsoZzB8j4rl8IQOFBAzPFxARrzAlzlc4E5fB3keUyxCfxYk3O6QvxVCa6yT-FTdqHnlCbssgWduLHFhHxxH7rDwmXkjlrkhn2Znoifq4FnaSDZUVkC7x7DDt6EMbeNImdIZGCdMGcSDWVPocGK0gtxWBIwRH5iOPgLBsFvlySF8zIpGdXnvsiXhm0vWLjCxIe4mPMROG2_fBRKQjaD6ZxfEFwTQJl9kxyhI3EuJZOvGgBLGV4QuXyXIgA3lsQvvHn5rFFU7lYwhUD1OwrkPlkFKJCcfEdgoFcTQ21gBL6_f7qWiMd5LMKk9SQpKzw8X0XhIqIpy3iyb2qz2yeYv1vLJ3sx0kVcBy_izpIF9JhBbx4y8a086ZT8Mp4TB7H6qSHImdqshBvndsyxCPDVRKAoSeoaRNIEvl1JHZ2CYsUIrg3UgMPCUguDiUShvlrqKbjMN0IHeFxIGgcr1D1ZMjohZPUhQNcf6IkBLzkeOtSFjZJqQ3RJZNctofXVZF9f4z03ZR_bVjTBpiBoELieYIMuVnWEkeqJ0VIjt1ImG1FPi9I02OlwKxZhNeEiesAtFGiY5yvMnO0N2AijUae4MfpTSUfSjF-EPm55iNtJNV3zlIPG9Jf9cEpJD-ZkX0h4WYVRFlkt-_dhKTFJFkDekgpSQkJI2dusiXrN47uGTGkpsQ_2wNVOJyQrwyFyUFWUpIimKfXfqq_cpYUlBoxUUEGPCFC6EqwGJsmA5QVOsgaCHDiPXTWbluNk5MS68aDaPebJiy_eez8nG9Xj-ptiy9ZdX0ulGXJbn-DI1Uo99Elk0C1Kwcp_yMdhFXHfA5LTps5ykKqTxr8wXWxcwXGJKiGDxSyVYkhmAufHGqDTvDy1KyDaOZPe2W2LR0RXzCXVu7DijhUzKb0aDUDcgYAvephv2VBgEdu99Otd8gnE_oqX5S-_2GAYm-bwNOSJ381k6831o7EK-zPCoht7i2E-o4zioRiI942KJeGkXj3Z3LXR5Rpre2QuNhSiQuJy25NbMRWnqP2HRcll3AvGJ-pKKqpbgSdaqZekl8H9Kvp1qjWQIj8Vzb5eGpZpR-42QSnhLB4O_xfKk5FHODuUfCqSbHWjIa5nfoRHJAWqra-DOIJ9TMqsaZVjXWvn4yDAM_JcLWpLRLn8yT6nf4IRm71nO5JodeMnIdShFqQoalT3VEEoPCZStmlUIcmvQ-4f-3zBmiyIR1gt8I-eFx2loSLXIQ1l6I6l6I2l6I-l6IxjpEW8TzvLuZu9wNXHk8LnXoxA01sIIAllyhaPq_r_25vtba5GtPuD_8e6aPT98b5rHR_Cg8Qewe49l34QL_0U5n7DX2_zq3tPJu-XjX__HxsgSydf1QCL8HiRf8jyIlAZgKmUT0FDT26qNM-ZRqCLHFngw9a09m6RrXPKGU_6kkqUFGyl5LGev63qgdmzUwLmlTqMNb4s405qPes5DCnL43rGOj8RHBvjfNY7P5cc2w8qar68dGTf-4ydIMfasxdbyEnDYO2AxZCbVXl09BBhC1pF9pXebHm0ch0h-4vib2HKN5boSmfmzpH3Oekp54kf2tkf5ft9blRtKeDA8SaY8BLOAMnh6HNyKX5nK9ocuUH_dMJlpSxVOBj9VraqPX5MBDso3YdwBJ7O6KrVHc0ivnqUkSf6evEIfkd_WOced9ppkFMDoF4WUPRYRxTj2-H9xYkV2RHjqzyKO8AEKPerNCCIlCiwybOQstewBMCQvm45fkrIViN4wXgR9idDaKIphFEawCCOhdZnFlGHnvUjXdIpxdwQrhuZC0JEZRBzSyMUyutHF9TRyIXLhk_kLxrFYoT6WIRS4-iXW6jHj-POJ4vkBcTLy8urrsPvQ_XyZdzNzQ_gXP2-AFw7grieJHsycaiNAvQUUN4hfZHEOO5BlJEU7jUgAegoRVdfQUym9nZSwEiI8XlBPXEzVezyPzcFmOW6cGk2J8OTBHS9DJfFOg9AWkFLiiKpwhdDmb47Eq6uDaX40lvFe3zozkBA_t4lkkJULyJmOOlEwQuiTk4sCwChVMYfNEsEVtKJBKEW9FtEmbygBw4HgGJBbemlA4ng-ZU9sdu7a6gJcXJPOySW50qNAQtxjz-HGTArK8UZjHTtpUpCpuM65INW5TsS9qk0UeO25SQE4PnOcJpM3M76G5KFC69GjH9fBs5Ypm75gvjB0CyRJAgeAthJj4dFue4D3k_EH6RYFSep4qXPOetF1FVng1Jy8m0aIyFrx7kkOVLUpe7655bNKmopbsrYl8KMt9USAVH9DNEZFtimqQmUteBXGbykjimwv5QSSNKo4iQm7nhbnOerRY-_hWgqIq8Q584an1dyCTXkxQoiVyjhVvSdoORH-EpSWszzdQEVVzNSLocG-jgH73Ngoi51PCHq7lIcPV7GMLZnJAeq3jCQ0Pxk8PUx9MQR75PhhdnEhXwcbQDxYrdlU2xP7lJ8VpZDOtEY_8C5CIslfsYWtz8DhsiPFMuXGkWyjGVV9x8XVDaIs_KAeSbYRgGu-p5otbKaX3MXqUePiTDMx7G8HVm79vIoa36aI58Z2E3P2mNL2wGmBVDTRFNe4CL-29VYY-nS02EEr5aleS5Vxb7GtqDsWKKolnXjz7ReZz6i9PN4ym7LXjvKANP4BKwtxO6B3j8jQ4Uk5e2l3mj91JvEEqX-ItUjGStCUpnXGXe1TMR3j6O66Xrawca-kqM_2hFLEaW8gAUskiJSvUcxaGCRpFyfRD0ZQDfoJBUeInG7USGut4LsokXdslSAOP2HTKPIcGKXNGXc91k7tPuQUlXQm7E9e7H4tRwPJmsqzK7ERbSiHZbObX8AeW8nhtzClIA6OeT_FOLNDxFruw8yNdu6S1Galm5LDye1IFeZVafwzV2DWWVRksKeDKWE3AI5uJQwT7EKwVgQQu3z-sRh4pvl8J7ipqz4caQGc2Y3u1v6KK9HZeAV1ARLCfi0tm5WbiZiRzXZxoKV8oEb-WsL_X2hp-9nbmNnXke838PJTS0FZvdSoNTexHFYBPbpgVkR56537FrpgEKkrBGpYyW5piNwrQENdv5W-jsRZvuywIojlue3WDxf54uKKIjZdTt_S9aUJxMc0SdTz7uYuHu0bUG6uNwKEz5l-xYLbfRJutHNP54r2CgtDccr92VklnVDnDi7cfSu3K2i_G_RtJqGr3

Before screenshot:

image

After screenshot:

image image

@Peechey Peechey changed the title Fix Ancestrally Boosted Strikes More Damage Multiplier Fix Ancestrally Boosted Strikes incorrectly having a base More Damage Multiplier Jul 12, 2026
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Aug 30, 2026
@LocalIdentity
LocalIdentity merged commit ec72557 into PathOfBuildingCommunity:dev Aug 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ancestrally Boosting a strike skill increases its damage

2 participants