Fix 2H weapons not removing off-hand items in comparisons - #2368
Merged
LocalIdentity merged 2 commits intoAug 30, 2026
Conversation
When you had Giant's Blood and compared a two hand mace vs a bow and quiver it wasn't showing the effect of removing the quiver Update the tests for the new format
LocalIdentity
approved these changes
Aug 30, 2026
LocalIdentity
merged commit Aug 30, 2026
5c7ce7f
into
PathOfBuildingCommunity:dev
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2252.
Description of the problem being solved:
The calculator repItem functionality was allowing many off-hand items to be used with 2H weapons. This fixes that, adds test for it, and allows for custom mods to affect the related code.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: