Add support for Runic ward - #2146
Merged
Merged
Conversation
…rit higher in side bar
Nightblade
reviewed
Jun 16, 2026
Blitz54
marked this pull request as ready for review
June 20, 2026 02:58
added 2 commits
August 31, 2026 08:22
Correct Runic Ward parsing from copied items and account imports while retaining support for the older Ward property name. Use the in-game “Runic Ward” name consistently across item displays, trade comparisons, costs, recovery, and breakdowns. Correct Runic Ward EHP and maximum-hit calculations so damage is taken from Life first, bypassed Ward is excluded, and remaining Ward is tracked properly. Include Runic Ward in damage-over-time pools and total/comprehensive net recovery. Apply redirected Energy Shield increases additively to Runic Ward without incorrectly applying Energy Shield more multipliers. Include doubled body-armour defence when calculating Ward. Add support for Runic Ward regeneration, degeneration, recovery on block, mana-regeneration recovery, and life-flask recovery. Add calculations for Leylines, Scouring Flame, Runic Infusion, Olroth’s Hubris, and Runic Reprieve costs. Distinguish between missing Runic Ward and having no Runic Ward in modifier conditions. Prevent costs derived from another resource from being counted multiple times as Ward costs. Remove an unrelated duplicate DPS multiplier application. Prevent item properties without a base value from incorrectly appearing as modified. Add regression tests covering parsing, importing, costs, recovery, degeneration, EHP, bypass behavior, and Energy Shield-to-Ward modifiers.
LocalIdentity
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds Ward into PoB2. Lots of the old code still functioned thankfully.