Skip to content

Fix digikey create from scan - #1517

Merged
jbtronics merged 4 commits into
Part-DB:masterfrom
d-buchmann:fix-digikey-create-from-scan
Sep 6, 2026
Merged

Fix digikey create from scan#1517
jbtronics merged 4 commits into
Part-DB:masterfrom
d-buchmann:fix-digikey-create-from-scan

Conversation

@d-buchmann

Copy link
Copy Markdown
Contributor

Fixes #1499.
Each of the commits fixes the issue individually.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.39%. Comparing base (0e1a932) to head (c947240).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
...s/InfoProviderSystem/Providers/DigikeyProvider.php 0.00% 2 Missing ⚠️
...nfoProviderSystem/Providers/OEMSecretsProvider.php 0.00% 1 Missing ⚠️
...System/BarcodeScanner/BarcodeScanResultHandler.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1517      +/-   ##
============================================
+ Coverage     61.82%   62.39%   +0.57%     
- Complexity     9728     9871     +143     
============================================
  Files           724      735      +11     
  Lines         31302    31745     +443     
============================================
+ Hits          19353    19808     +455     
+ Misses        11949    11937      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbtronics

jbtronics commented Sep 6, 2026

Copy link
Copy Markdown
Member

The underlying issue is that urlencode() is encoding a space not as %20 which would be correct, but as + character, which digikey then interprets as an actual + character.

Using rawurlencode() gives the correct behavior. Without the escaping we would probably run into other issues, when the ID contains an slash or something.

Thanks for the PR.

@jbtronics
jbtronics merged commit b805276 into Part-DB:master Sep 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create parts and lots from digikey barcode results in 500

2 participants