Skip to content

spec(intent-4): cross-skill deregistration needs a non-mirroring transport - #258

Draft
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-4-cross-skill-deregister-transport
Draft

spec(intent-4): cross-skill deregistration needs a non-mirroring transport#258
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-4-cross-skill-deregister-transport

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 9, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5.1 (claude-fable-5-1) via Claude Code — NOT human-reviewed. Verify before acting.

INTENT-4 §8.4 gains a paragraph stating that the cross-skill deregistration (payload target differs from the context source) is carried only by a transport that delivers ovos.skill.deregister on its own, and that a producer MUST NOT emit it through a client that mirrors the topic onto detach_skill. Self-deregistration is unaffected. The divergence row for detach_skill records why: predecessor handlers resolve the skill from context, so the mirrored copy removes the source's registrations too. CHANGELOG entry under INTENT-4.

What the reader decides: whether the constraint belongs on the producer (as written) or on the mirroring client. Miro ruled this a property of the transport rather than a defect in any handler, and the text follows that ruling.

Verified against source by model re-check, not human review: ovos-spec-tools MIGRATION_MAP maps detach_skill to ovos.skill.deregister (messages.py:460 at dev 3f116a8); harness live evidence in knowledge/wiki/audits/gate-ledger/live-ovos-adapt-pipeline-plugin-76.md and live-ovos-padatious-pipeline-plugin-153.md shows the source's intents destroyed on the default dual-emit bus and intact with the mirror off.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl force-pushed the spec/intent-4-cross-skill-deregister-transport branch 2 times, most recently from 666e913 to df52354 Compare September 9, 2026 03:12
… does not mirror onto detach_skill

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@JarbasAl
JarbasAl force-pushed the spec/intent-4-cross-skill-deregister-transport branch from df52354 to 691b56f Compare September 9, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant