spec(intent-4): cross-skill deregistration needs a non-mirroring transport - #258
Draft
JarbasAl wants to merge 1 commit into
Draft
spec(intent-4): cross-skill deregistration needs a non-mirroring transport#258JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JarbasAl
force-pushed
the
spec/intent-4-cross-skill-deregister-transport
branch
2 times, most recently
from
September 9, 2026 03:12
666e913 to
df52354
Compare
… does not mirror onto detach_skill Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JarbasAl
force-pushed
the
spec/intent-4-cross-skill-deregister-transport
branch
from
September 9, 2026 15:48
df52354 to
691b56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTENT-4 §8.4 gains a paragraph stating that the cross-skill deregistration (payload target differs from the context source) is carried only by a transport that delivers
ovos.skill.deregisteron its own, and that a producer MUST NOT emit it through a client that mirrors the topic ontodetach_skill. Self-deregistration is unaffected. The divergence row fordetach_skillrecords why: predecessor handlers resolve the skill fromcontext, so the mirrored copy removes the source's registrations too. CHANGELOG entry under INTENT-4.What the reader decides: whether the constraint belongs on the producer (as written) or on the mirroring client. Miro ruled this a property of the transport rather than a defect in any handler, and the text follows that ruling.
Verified against source by model re-check, not human review: ovos-spec-tools
MIGRATION_MAPmapsdetach_skilltoovos.skill.deregister(messages.py:460 at dev 3f116a8); harness live evidence inknowledge/wiki/audits/gate-ledger/live-ovos-adapt-pipeline-plugin-76.mdandlive-ovos-padatious-pipeline-plugin-153.mdshows the source's intents destroyed on the default dual-emit bus and intact with the mirror off.