Skip to content

spec(audio-in-1): ovos.listener.wake, the request that ends sleep mode - #253

Draft
JarbasAl wants to merge 1 commit into
devfrom
spec/audio-in-1-wake-request
Draft

spec(audio-in-1): ovos.listener.wake, the request that ends sleep mode#253
JarbasAl wants to merge 1 commit into
devfrom
spec/audio-in-1-wake-request

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 8, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5.1 (claude-fable-5-1) via Claude Code — NOT human-reviewed. Verify before acting. Clauses read from origin/dev at d9169ee; shipped-code claims name their file. Nothing was run against a live bus.

Closes #164.

The gap. AUDIO-IN-1 §6.3 defines ovos.listener.sleep and §6.4 defines the ovos.listener.awoken signal, but no topic asks the listener to wake. A component that put the listener to sleep has no sanctioned way to wake it short of the wake word. The shipped listener binds the pre-spec spelling: ovos-dinkum-listener service.py:450 subscribes recognizer_loop:wake_up next to the spec ovos.listener.sleep at :449, and ovos-spec-tools maps recognizer_loop:sleep and mycroft.awoken (messages.py:441-442) but has no row for the wake request.

The clause. §6.4 becomes "Wake request and awoken": ovos.listener.wake, controller → audio-input, no payload, session informational only and device-scoped exactly as §6.3 states for sleep; a request while awake is a no-op that emits nothing; ovos.listener.awoken follows the transition as before, "by this request or otherwise". §6.6 gains the row, §8 the MUST, CHANGELOG the entry, appendix/divergences.md the migration row from recognizer_loop:wake_up. Version stays 2.

Wire. One new topic, a rename of a shipped one. Miro rules; after that ovos-spec-tools gains LISTENER_WAKE and the MIGRATION_MAP row, and the listener subscribes to both spellings for one stable cycle.

Overlap. architecture#230 edits §6.3 and §6.6 of the same file; whichever merges second rebases.

#164)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audio-in spec names no wake-request topic (recognizer_loop:wake_up has no successor)

1 participant