spec(audio-in-1): ovos.listener.wake, the request that ends sleep mode - #253
Draft
JarbasAl wants to merge 1 commit into
Draft
spec(audio-in-1): ovos.listener.wake, the request that ends sleep mode#253JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
#164) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164.
The gap. AUDIO-IN-1 §6.3 defines
ovos.listener.sleepand §6.4 defines theovos.listener.awokensignal, but no topic asks the listener to wake. A component that put the listener to sleep has no sanctioned way to wake it short of the wake word. The shipped listener binds the pre-spec spelling:ovos-dinkum-listenerservice.py:450subscribesrecognizer_loop:wake_upnext to the specovos.listener.sleepat:449, andovos-spec-toolsmapsrecognizer_loop:sleepandmycroft.awoken(messages.py:441-442) but has no row for the wake request.The clause. §6.4 becomes "Wake request and awoken":
ovos.listener.wake, controller → audio-input, no payload, session informational only and device-scoped exactly as §6.3 states for sleep; a request while awake is a no-op that emits nothing;ovos.listener.awokenfollows the transition as before, "by this request or otherwise". §6.6 gains the row, §8 the MUST, CHANGELOG the entry,appendix/divergences.mdthe migration row fromrecognizer_loop:wake_up.Versionstays 2.Wire. One new topic, a rename of a shipped one. Miro rules; after that
ovos-spec-toolsgainsLISTENER_WAKEand theMIGRATION_MAProw, and the listener subscribes to both spellings for one stable cycle.Overlap. architecture#230 edits §6.3 and §6.6 of the same file; whichever merges second rebases.