spec(SESSION-1): transformer denylists belong to the per-component override class - #244
Draft
JarbasAl wants to merge 1 commit into
Draft
spec(SESSION-1): transformer denylists belong to the per-component override class#244JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
…erride class Two clauses enumerating the per-component override field class (OVOS-PIPELINE-1 §5.5 defers to this enumeration) were incomplete: §3.4 and §6's producer **SHOULD NOT** list both included the six *_transformers lists and the three basic blacklisted_* denylists, but omitted the six blacklisted_*_transformers lists also owned by the same policy class (OVOS-TRANSFORM-1 §5.2). This left two implementers free to disagree on whether a plugin's updated_session may relax transformer denylists, since one implemented against the partial enumeration and one against the full field table in §3. Both clauses now read "pipeline, the six *_transformers lists, the six blacklisted_*_transformers lists, blacklisted_skills, blacklisted_intents, blacklisted_pipelines, or site_id" — the authoritative policy-class roster. No other fields or clauses altered; fallback_handlers remains correctly excluded (owned by handlers, not policy). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OVOS-PIPELINE-1 §5.5 defers to OVOS-SESSION-1's enumerations of the per-component override field class when deciding which fields a plugin's
updated_sessionmay relax. Two clauses enumerate this class: §3.4's wire-weight rule and §6's producer SHOULD NOT guidance. Both were incomplete: they listed the six*_transformerschains and the three basicblacklisted_*denylists but omitted the sixblacklisted_*_transformerslists, which belong to the same class per OVOS-TRANSFORM-1 §5.2. This left two implementers free to disagree on whether a plugin may relax transformer denylists, since one read against the partial enumeration and one against the authoritative field table in §3.Both clauses now read "pipeline, the six
*_transformerslists, the sixblacklisted_*_transformerslists, blacklisted_skills, blacklisted_intents, blacklisted_pipelines, or site_id" — the complete policy-class roster. No other fields or sections altered;fallback_handlersremains correctly excluded (owned by the handler policy, not the component-override policy).The governing clause OVOS-PIPELINE-1 §5.5 states: "The orchestrator also re-imposes every per-component override field (OVOS-SESSION-1 §3) onto any updated_session a plugin returns... This class is deployment-owned in its entirety, not by naming individual members here." This PR aligns both enumerations to the full membership of that class.