Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This was referenced Nov 5, 2026
Once a distance below 1e-16 has returned, the core-axis test needs a distance below 1e-24 * 4 alpha nu / va, so an inflow under 7e-13 m/s. A solve refuses zero inflow before it builds the influence matrices. The docstring named the wrong function and arguments; it now gives the right ones and says what happens inside the core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
From the #318 branch: Gaunaa et al. 2026's straight elliptic wing reaches 1 with the quarter-chord flow turning the force, and stays below 0.8 without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Local full suite: PASS (26 min, Julia 1.13.3, one cell of the matrix) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia was translated from Python v1.0.0, and Python's v2.3.0 changed its default results. On swept and curved wings, which is every kite, the two had drifted several percent apart. With this branch, Julia matches Python's circulation, angles, per-panel forces and moments, totals and coefficients to six digits on nine reference cases generated by running the Python code.
What moved: circulation now follows the effective speed. The chord and chordwise axis are measured square to the bound vortex. Forces turn with the flow at the quarter chord, including a correction for a curved bound vortex, and drag runs along that flow. The force on the chordwise legs is on by default and shared per section boundary. Each wake follows its own panel's inflow, and reference pressure and directions leave out body rates. The defaults also change to 5000 iterations and a relaxation factor of 0.8 of the stability limit, so the curved reference wing that used to diverge now converges.
The same default change ends the lost induced drag of #318: the straight elliptic wing of aspect ratio 4 from Gaunaa, Li & Pirrung 2026 now reaches an Oswald efficiency of 0.9947, against 0.7295 with the quarter-chord force direction off.
Agreeing with Python does not make swept wings right. Against that paper's vortex-lattice results, Oswald efficiency is off by −8.2 % at 15 % sweep, −8.0 % at 10 % sweep with 25 % anhedral and −11.1 % at 25 % sweep, where the solver does not converge. The paper's own model is off by +5.6 %, −0.5 % and +1.1 %. Purely curved wings are off by ±2.4 %. These were measured on the previous head by the task behind #400, whose card plots them, and the chord direction on the swept wings is an assumption. #416 tracks the gap; closing it may mean leaving Python's rule, which is the owner's choice.
Anyone relying on the defaults gets new numbers, including KiteModels wherever its settings do not name these options. Setting the two force options to false and naming a relaxation factor restores those switches, but not the geometry or circulation changes.
Decisions I made:
Found on the way: faster convergence exposed that unrefined section coefficients were plain means, so they are now area-weighted, with the same code as #402. A semi-infinite filament now gives zero rather than NaN on its own axis, as #408 also does.
This covers default results only, so the issue stays open. The missing features are queued as parts of it. Left out: bridle drag, which stays in KiteModels as ruled on #113, and the other items declined there (flat area, rotate, cosine circulation, configurable aerodynamic-centre fractions) unless the owner says otherwise.
To act on: stacked on #392, which merges first. It takes a different route from #400, whose rule is not Python's, and from #408's core scaling. It conflicts with #402 in the solver, where the aggregation code is identical. SymbolicAWEModels calls the drag-direction helper with an argument that is now gone, so it needs a one-line change when it raises its bound to the release #392 forces.
Verification
test/verification/test_python_reference.jl: green on nine cases (straight, swept, arc, sideslip, LLT, viscous, body rates, distributed inflow, V3). Red before: run through a script on the unchanged code, since the test itself names functions this branch addstest/verification/test_verification.jl: the aspect-ratio-4 test is green, 24/24 in the file; red with the quarter-chord force direction disabled (0.7295, 23/24)test/bench.jl,test_verification.jl,test_curved_bound_correction.jl,test_forwarddiff.jlcalc_forces!stays at 0 B with the new defaults; one rebuild of the correction took 4.2 ms at 20 panels on a loaded box, growing with panels squaredclis checked against the control-point angle. The NaN assertion on the filament axis is now zero. One trim call tightens its angle tolerance to 1e-6, since its 1e-5 assertion sat at 1.17e-5.test/data/python_reference/generate_reference.pyCloses #318
Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Refs #410 · task
VortexStepMethod.jl-410