Require Qt 5.12 API - #2513
Conversation
|
I assume that workarounds for QT < 5.12 could be removed as well, e.g. in |
|
Yes, there can be more cleanup. But it can be done in different PRs. FTR I just fixed the problem with the app not starting with Qt 5.15 for Android. There is still a glitch with the full screen mode being shifted by the size of the camera notch. |
|
More importantly, it is 0x050c00, not 0x051200 🤦 |
|
Okay, CI here is happy, and it also build for Linux, Windows (MSVC), Android, MacOS (inc. arm64). So it can be merged with rebase soon. |
Fix implicit instantiation of undefined template 'QHash<QString, QtAndroid::PermissionResult>' and 'does not provide a subscript operator'.
I added a commit to remove such code. |
| // images. This can be worked around by setting a real brush. | ||
| // Fixed in Qt 5.12.0. | ||
| /// \todo Fix image opacity in AdvancedPdfEngine | ||
| #if QT_VERSION < 0x051200 |
There was a problem hiding this comment.
Look, another wrong version constant!
There was a problem hiding this comment.
I must have seen it, but it never caught my eye, although it's obvious ;-)
There was a problem hiding this comment.
OMG, I did the same mistake in one of my PRs:
#if QT_VERSION < 0x051500
| if (cursor_pos.x() > screen_rect.right() - total_radius) | ||
| cursor_pos.setX(screen_rect.right() - total_radius); | ||
| else if (cursor_pos.x() < total_radius) | ||
| cursor_pos.setX(total_radius); | ||
|
|
||
| if (cursor_pos.y() > screen_rect.bottom() - total_radius) | ||
| cursor_pos.setY(screen_rect.bottom() - total_radius); | ||
| else if (cursor_pos.y() < total_radius) | ||
| cursor_pos.setY(total_radius); | ||
| } | ||
|
|
||
| setGeometry(pos.x() - total_radius, pos.y() - total_radius, 2 * total_radius, 2 * total_radius); |
There was a problem hiding this comment.
cursor_pos is still unused after this PR, but that's a different topic and PR.
2 participants
No description provided.