Remove always-false array-length check in ForgeRockTestListener#297
Open
vharseko wants to merge 1 commit into
Open
Remove always-false array-length check in ForgeRockTestListener#297vharseko wants to merge 1 commit into
vharseko wants to merge 1 commit into
Conversation
checkForInterleavedBetweenClasses wrapped a single ITestNGMethod.getInstance() value into a one-element array and then tested testInstances.length != 1, a condition that is always false (dead branch flagged by CodeQL java/constant-comparison). Use the single test instance directly and drop the useless array allocation and comparison.
vharseko
added
codeql
maximthomas
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a CodeQL
java/constant-comparisonalert ("Useless comparison test / Test is always false") inForgeRockTestListener.checkForInterleavedBetweenClasses.The method wrapped a single
ITestNGMethod.getInstance()value into a one-element array literal and then testedtestInstances.length != 1— a condition that can never be true, so the guard was dead code (likely a leftover from an earliergetInstances()array API).Change
No behavior change: the length guard never protected anything since the array always had exactly one element.
Closes code scanning alert #2089.