studio: the first tab is where you look at the picture, so it says so - #36
Merged
Merged
Conversation
"Develop" is darkroom language -- turning a latent image into a visible one -- and a camera owner has no reason to know it. It is "Preview" now, next to "Bad pixels", for the same reason that one stopped being "Diagnose": the tab bar should say what is behind each tab in words its reader already has. It understates the tab a little, and that is the trade. Preview is not only a preview: Black, White and Exposure are in there, along with the white balance and the choice of demosaic, and all of them change what the picture looks like. But "Develop" overstates the jargon by more than "Preview" understates the controls, and someone who drags a slider finds out what it does immediately. The copy that names the tab moves with it -- the plate reader's warning about the demosaic in force says "Preview is set to Bilinear" now. What does NOT move: the mode key `develop`, the worker call of the same name, and the progress text while a frame is being rendered. The first two are internal. The third is describing the operation rather than the tab, and the operation really is a develop: a demosaic and a render, from a mosaic that is not yet a picture.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can choose which labels appear on a finding, and whether they show icons or text |
PR Summary by QodoRename Studio’s Develop tab to Preview
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developis darkroom language — turning a latent image into a visible one —and a camera owner has no reason to know it. It reads Preview now, beside
Bad pixels, for the same reason that one stopped being Diagnose: the tab
bar should say what is behind each tab in words its reader already has.
It understates the tab a little, and that is the trade. Preview is not only
a preview — Black, White and Exposure live there, along with the white balance
and the choice of demosaic, and every one of them changes what the picture
looks like. But Develop overstates the jargon by more than Preview
understates the controls, and someone who drags a slider finds out what it does
straight away.
The copy that names the tab moves with it: the plate reader's warning about the
demosaic in force now says "Preview is set to Bilinear".
What does not move — the mode key
develop, the worker call of the samename, and the progress text shown while a frame is rendered. The first two are
internal, and renaming them would be churn with nothing visible at the end.
The third describes the operation rather than the tab, and the operation really
is a develop: a demosaic and a render, from a mosaic that is not yet a picture.
Label only, no behaviour change. The 17 checks that clicked the tab by its name
move to the new one.