Skip to content

studio: the first tab is where you look at the picture, so it says so - #36

Merged
openipc-ai merged 1 commit into
mainfrom
tab-preview
Sep 24, 2026
Merged

openipc-ai merged 1 commit into
mainfrom
tab-preview

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

Develop is darkroom language — turning a latent image into a visible one —
and a camera owner has no reason to know it. It reads Preview now, beside
Bad pixels, for the same reason that one stopped being Diagnose: the tab
bar should say what is behind each tab in words its reader already has.

It understates the tab a little, and that is the trade. Preview is not only
a preview — Black, White and Exposure live there, along with the white balance
and the choice of demosaic, and every one of them changes what the picture
looks like. But Develop overstates the jargon by more than Preview
understates the controls, and someone who drags a slider finds out what it does
straight away.

The copy that names the tab moves with it: the plate reader's warning about the
demosaic in force now says "Preview is set to Bilinear".

What does not move — the mode key develop, the worker call of the same
name, and the progress text shown while a frame is rendered. The first two are
internal, and renaming them would be churn with nothing visible at the end.
The third describes the operation rather than the tab, and the operation really
is a develop: a demosaic and a render, from a mosaic that is not yet a picture.

Label only, no behaviour change. The 17 checks that clicked the tab by its name
move to the new one.

"Develop" is darkroom language -- turning a latent image into a visible one --
and a camera owner has no reason to know it. It is "Preview" now, next to
"Bad pixels", for the same reason that one stopped being "Diagnose": the tab
bar should say what is behind each tab in words its reader already has.

It understates the tab a little, and that is the trade. Preview is not only a
preview: Black, White and Exposure are in there, along with the white balance
and the choice of demosaic, and all of them change what the picture looks like.
But "Develop" overstates the jargon by more than "Preview" understates the
controls, and someone who drags a slider finds out what it does immediately.

The copy that names the tab moves with it -- the plate reader's warning about
the demosaic in force says "Preview is set to Bilinear" now.

What does NOT move: the mode key `develop`, the worker call of the same name,
and the progress text while a frame is being rendered. The first two are
internal. The third is describing the operation rather than the tab, and the
operation really is a develop: a demosaic and a render, from a mosaic that is
not yet a picture.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can choose which labels appear on a finding, and whether they show icons or text

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Rename Studio’s Develop tab to Preview

✨ Enhancement 🧪 Tests 🕐 Less than 10 minutes

Grey Divider

AI Description

• Renames the user-facing Develop tab to Preview while preserving internal develop behavior.
• Aligns demosaic warnings, distributable output, comments, and 17 UI tab selectors.
Diagram

graph TD
  Source["Source editor"] --> Bundle["CDN bundle"] --> UI["Preview tab"] --> Mode["develop mode"] --> Worker["Develop worker"]
  Mode --> Warning["Demosaic warning"]
  Tests["UI checks"] --> UI
Loading
High-Level Assessment

The PR’s approach is optimal: rename only user-facing terminology while retaining the stable develop mode key, worker call, and operation progress language. A full internal rename was considered but would add churn and regression risk without improving the interface.

Files changed (3) +39 / -29

Enhancement (2) +22 / -12
editor.jsPublish the Preview label in the CDN bundle +11/-6

Publish the Preview label in the CDN bundle

• Renames the distributed Studio tab from Develop to Preview and updates its demosaic warnings and related comments. The internal 'develop' value and rendering behavior remain unchanged.

dist/editor.js

editor.jsRename the Studio tab and warnings to Preview +11/-6

Rename the Studio tab and warnings to Preview

• Changes the user-facing Develop tab label to Preview and explains why the internal mode key remains 'develop'. Plate-reader demosaic warnings and nearby comments now use the new tab name.

src/editor.js

Tests (1) +17 / -17
ui-check.htmlSelect the renamed Preview tab in UI checks +17/-17

Select the renamed Preview tab in UI checks

• Updates 17 browser test interactions to locate the tab by its new Preview label. Existing lifecycle, demosaic, focus, calibration, and autofocus behavior coverage is preserved.

tests/ui-check.html

@openipc-ai
openipc-ai merged commit d05c31a into main Sep 24, 2026
1 check passed
@openipc-ai
openipc-ai deleted the tab-preview branch September 24, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant