Add file_client and file_server examples#391
Open
maksimdrachov wants to merge 1 commit into
Open
Conversation
pavel-kirienko
requested changes
Jun 29, 2026
pavel-kirienko
left a comment
pavel-kirienko
left a comment
Member
There was a problem hiding this comment.
please bump the dev version number so that it's published
Comment on lines
+27
to
+30
| REQUEST_DELIVERY_TIMEOUT = RESPONSE_TIMEOUT / 2.0 | ||
| REQUEST_HEADER_FORMAT = "<QH" | ||
| RESPONSE_HEADER_FORMAT = "<IH" | ||
| RESPONSE_HEADER_SIZE = struct.calcsize(RESPONSE_HEADER_FORMAT) |
Member
There was a problem hiding this comment.
These belong in the dataclasses and they should be private with exposed serialize/deserialize methods. Maybe we should even move them into a shared module to reduce duplication between the examples.
| data: bytes | ||
|
|
||
|
|
||
| def _encode_request(file_path: str, read_offset: int) -> bytes: |
Member
There was a problem hiding this comment.
same, broken encapsulation
| if request is None: | ||
| _logger.debug("dropping malformed request of size %d", len(arrival.message)) | ||
| continue | ||
| task = asyncio.create_task(_serve_request(arrival, request), name=f"file:{arrival.breadcrumb.tag}") |
Member
There was a problem hiding this comment.
I think this example would benefit from doing it sequentially to focus more on Cyphal rather than asyncio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.