Skip to content

refactor(game): rework team allocation and add GamePrepareEvent hook#130

Merged
theEvilReaper merged 4 commits into
mainfrom
rework/teamHandling
Jul 5, 2026
Merged

refactor(game): rework team allocation and add GamePrepareEvent hook#130
theEvilReaper merged 4 commits into
mainfrom
rework/teamHandling

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

Adds the GamePrepareEvent as a trigger for stamina initialization and uses that as an opportunity to split TeamHelper.prepareTeamAllocation into clearly separated steps (selection, tagging, assignment).

The survivor set is now returned explicitly as a TeamAllocation instead of being re-fetched from the team object later on.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 5, 2026
@theEvilReaper theEvilReaper added the area: game Everything related to the the game module label Jul 5, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Test results

 96 files   96 suites   50s ⏱️
 93 tests  88 ✅  5 💤 0 ❌
282 runs  267 ✅ 15 💤 0 ❌

Results for commit e429123.

♻️ This comment has been updated with latest results.

@theEvilReaper theEvilReaper merged commit 78eeb97 into main Jul 5, 2026
7 checks passed
@theEvilReaper theEvilReaper deleted the rework/teamHandling branch July 5, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant