Repository navigation
fix: show Ukrainian language name in translation report - #3701
Open
prajakta128 wants to merge 1 commit into
Open
prajakta128 wants to merge 1 commit into
prajakta128 wants to merge 1 commit into
Conversation
The report's language display-name map did not include uk, so Ukrainian sections were headed with the raw locale code. Add the missing mapping and a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The translation report did not include a mapping for the
uklocale. As a result, Ukrainian issues were displayed under## ukinstead of## Ukrainian, making the report less readable.Solution
Added the missing
uklocale mapping inscripts/check_translations.pyand a regression test inscripts/check_translations_utest.pyto ensure Ukrainian issues appear under the correct heading.Testing
source/directory displays## Ukrainian.