Roll back travis host to focal#373
Conversation
…d offset for master/main builds.
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates libdap to version 3.22.0, adds release documentation, changes Travis scan Java provisioning to OpenJDK 21, and revises build-offset handling for pull requests. ChangesRelease and CI updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.coverage.md`:
- Line 56: Update the operating-system reference in the gcovr note to say Ubuntu
Focal instead of Ubuntu Jammy, keeping the surrounding explanation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 16102cc8-ca02-478f-810e-cb6bfa783b94
📒 Files selected for processing (7)
.travis.ymlChangeLogINSTALLNEWSREADME.coverage.mdconfigure.actravis/travis_libdap_build_offset.sh
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.coverage.md`:
- Line 56: Update the operating-system reference in the gcovr note to say Ubuntu
Focal instead of Ubuntu Jammy, keeping the surrounding explanation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 16102cc8-ca02-478f-810e-cb6bfa783b94
📒 Files selected for processing (7)
.travis.ymlChangeLogINSTALLNEWSREADME.coverage.mdconfigure.actravis/travis_libdap_build_offset.sh
🛑 Comments failed to post (1)
README.coverage.md (1)
56-56: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Doc says "Ubuntu Jammy" but this PR (and the referenced .travis.yml comment) indicate the host is Focal.
The PR objective is to roll back the Travis host from Jammy to Focal, and the
.travis.ymlscan step comment references "the version bound to focal" for the gcovr default. This note should say Ubuntu Focal, not Jammy, or it will mislead contributors about which OS/gcovr default is relevant.📝 Proposed fix
-> Note that Ubuntu Jammy uses `gcovr` 5.x by default, and thus in Travis we force the 'scan' +> Note that Ubuntu Focal uses `gcovr` 5.x by default, and thus in Travis we force the 'scan' > step to use 8.2 using a `pip` install. Make sure to test the version of `gcovr` using📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.> Note that Ubuntu Focal uses `gcovr` 5.x by default, and thus in Travis we force the 'scan'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.coverage.md` at line 56, Update the operating-system reference in the gcovr note to say Ubuntu Focal instead of Ubuntu Jammy, keeping the surrounding explanation unchanged.
|
@ndp-opendap Is there any need to reset the build offset number? |
|
2 participants
Roll back travis host to focal
Description
Because making the BES travis host jammy looks like it's going to be a thing.
And we can't link to the jammy built libdap rpms on a focal system.