languages/http: init - #1672
Conversation
Pull request was converted to draft
|
Currently doesn't work, due to missing CLI deps from |
e3531d4 to
70313c5
Compare
|
Required Compat was added Upstream, works as expected :3 |
|
DISCLAIMER: As I'm not familiar with nix, I could be totally wrong reading what this PR does. I just wanted to mention that if it's true that nix ships with kulala-fmt (+ the required kulala-core version by kulala-fmt) and you use the same version (of kulala-core) in kulala.nvim and kulala-fmt, that is probably going to break things. The whole reason I made it this modular, is that not every update needs to exist in all tools. Some things that we fix (like the oauth browser flow) in Core, don't need to be pushed to the formatter. The formatter never touches anything oauth related. So the formatter is sometimes quite a bit behind when it comes to the core version it requires. But we also already had it the other way around, there were things added to core to support certain features in kulala-fmt and then kulala-fmt had a newer kulala-core dependency than kulala-cli, kulala.vscode and kulala.nvim and kulala for desktop 🤷🏾 So: There is no guarantee that version xy of core will work in all tools at the same time. That's why all tools have a specific version constrained attached to them. |
The Formatter (which is handeled by conform) is independent of the plugin. thanks to the way linking works in nix, there is no kind of conflict between formatter and extensions.
We dont use the same. |
|
Yes, could be still me not knowing nix but all kulala tools have a core dependency (Kulala-Core). They don't ship with it, but download it on demand. This version differs per tool. They download the dependency in the platforms cache location though in a structure like I'm not sure how that is handled by nix, since I heard that nix says it's immutable. With tools like kulala that isn't the case anymore, if you don't download the core yourself build it and then set at least the env var. Sorry, if this is totally wrong and already covered by nix. Or my definition of immutable is different than what nix offers. Downloading a dependency during runtime isn't immutable to me. |
|
the kulala fmt in nixpkgts is actually pretty old, its at 1.4.0, so it still has everything bundled lmfao. I feel like we should package the whole thing from scratch for NVF 🤔 |
|
Noticed another problem, |
| defaultFormat = ["kulala-fmt"]; | ||
| formats = { | ||
| kulala-fmt = { | ||
| command = getExe pkgs.kulala-fmt; |
There was a problem hiding this comment.
TODO: package myself
|
rebased |
|
rebased |
|
rebased |
|
rebased |
a0c4b14 to
a03074f
Compare
d0dec20 to
fa22a56
Compare
|
cool github closes MRs when you rename a branch :/ |
Adds support for the JetBrains HTTP Language/Format
Closes: #1663
Closes: #1641
Needs: #1744
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.