[WIP] Add a Screenshots page to handle user captures - #23909
Draft
Pickysaurus wants to merge 64 commits into
Draft
Pickysaurus wants to merge 64 commits into
Pickysaurus wants to merge 64 commits into
Conversation
Tabs now show the filtered images
steam.ts sourcesByDiscovery.ts MediaPage.tsx Are now all tested
Reverted files in commit Nexus-Mods#23918
|
This PR has been marked as stale due to inactivity. |
…ith repo conventions Review pass over the new Media extension. Behaviour: - setGameMediaSourceEnabled replaced the whole disabledSources map with the active game's entry, wiping every other game's list. Merge instead. - deleteGameMediaModTag returned undefined for media with no tags, which clears the slice. Return state unchanged. - The mod search GraphQL document carried a stray "Variables" token after the closing brace, so every query was rejected as a parse error. - getSteamMedia was handed String(steamAppId), which is the truthy string "undefined" for games without a Steam id, so it preferred that over the id resolved from the install path. - "Open Folder" called shell.openUrl, which does new URL(path) in main and throws on a Windows path. Use shell.openFile, which goes via pathToFileURL. - ffmpeg's error listener was the promise's resolve, so a spawn failure resolved the Error as the thumbnail path; it also rejected inside Promise.all and took the whole scan down with it. - collectMedia sorted on a possibly-undefined createdAt (NaN) and matched extensions case-sensitively, skipping .PNG and .JPG. - Selectors returned a fresh [] for games with no disabled sources and media with no tags. Under react-redux's reference equality that re-rendered on every dispatch, and because the array feeds the collect effect's deps it re-scanned in a loop. Share module-level empties. - Media paths go through pathToFileURL so filenames containing # or % load. Structure and conventions: - Split source discovery out of useGameMedia into useGameMediaSources, so opening Settings lists sources without triggering a disk scan. - Add selectors.ts and drop the IStateWithGameMedia casts. - Move reducerFor to util/ — it was never health-check specific. - Drop the local joinClasses and XOr/ResponsiveScreenSizes copies in favour of @/ui/utils. - Drop setupMocks for the shared renderer test-setup, extended with ResizeObserver and the window.api members the media tests need. - Register the media_page namespace and move hardcoded strings into it; components call useTranslation rather than taking t as a prop. - Route tag removal through deleteGameMediaModTag everywhere instead of rewriting the whole tag array. - Cache the ffmpeg probe, group grid items by source once, use crypto.randomUUID, detect ENOENT by code, fix the page id and menu icon, and mark the custom source path read-only.
Added a new hook to watch the source folders and update the view if a new image is created or removed.
Show 24 items per page to prevent the page becoming massive when the user has lots of screenshots
Mock the Steam singleton to avoid Linux getting upset. Changed the MediaListItem and FloatingSearchBarResult to buttons for accessibility
Previews generated for videos are now cleaned up on app start. Fixed more tests for Linux
Fixed more Linux tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working progress: this PR adds a new page to Vortex that handles collating and displaying screenshots and video captures from multiple sources (e.g. Steam, Xbox, native game screenshot feature). Once an image upload API is available, it will also allow one-click sharing of images to the site image share.
Requires #23918 for full functionality