feat: add affinity and nodeSelector to common daemonset config - #2645
Open
amarkdotdev wants to merge 2 commits into
Open
feat: add affinity and nodeSelector to common daemonset config#2645amarkdotdev wants to merge 2 commits into
amarkdotdev wants to merge 2 commits into
Conversation
amarkdotdev
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
July 16, 2026 16:40
amarkdotdev
force-pushed
the
feat/daemonset-affinity-nodeselector-2626
branch
3 times, most recently
from
July 21, 2026 19:23
f0aa669 to
530835d
Compare
amarkdotdev
force-pushed
the
feat/daemonset-affinity-nodeselector-2626
branch
from
July 27, 2026 20:29
530835d to
be752b6
Compare
Author
|
Hey, this is waiting on CI workflow approval / first-time contributor vetting. Could a maintainer kick that off when convenient? Thanks! |
Contributor
|
/ok-to-test be752b6 |
Expose spec.daemonsets.affinity and spec.daemonsets.nodeSelector on ClusterPolicy and wire them through Helm. User nodeSelector labels are merged with existing operand nodeSelector entries. Use a schemaless CRD field for affinity so we do not embed the full corev1.Affinity OpenAPI schema in the ClusterPolicy CRD. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
Regenerate published GPUCluster CRDs for the common daemonset affinity and nodeSelector API fields. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
amarkdotdev
force-pushed
the
feat/daemonset-affinity-nodeselector-2626
branch
from
July 28, 2026 18:25
be752b6 to
9efb8b7
Compare
Author
|
@rajathagasthya Fixed the generated GPUCluster CRDs and rebased the branch onto upstream/main. |
Contributor
|
Thanks @amarkdotdev! We are in a bit of a code freeze right now for an upcoming release, so we're only taking release-critical PRs. You can expect this PR to get attention once the release is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2626
ClusterPolicy already exposes common tolerations for operand daemonsets but there was no matching knob for affinity or nodeSelector. This adds both under
spec.daemonsetsand surfaces them in Helm asdaemonsets.affinityanddaemonsets.nodeSelector.User nodeSelector labels are merged into the operand nodeSelector, so the existing
nvidia.com/gpu.deploy.*labels stay put.The affinity CRD field is schemaless so we accept a normal Kubernetes affinity object without inlining the full OpenAPI schema into the ClusterPolicy CRD.
Testing