Fix stale thread-layout comment in wgmma_sm90 tutorial#3363
Open
aryanputta wants to merge 1 commit into
Open
Conversation
The copyA/copyB tiled-copy comments in gemm_nt read "Thr layout 32x4", but the thread layout is Layout<Shape<_16,_8>>, i.e. 16x8. The matching k-major copies a few lines below already label the same Shape<_16,_8> as "16x8", so correct the m-major/n-major comments to match. Fixes NVIDIA#3340 Signed-off-by: Aryan <aryansputta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
examples/cute/tutorial/hopper/wgmma_sm90.cu, thegemm_nttiled-copy comments forcopyA/copyBreadThr layout 32x4, but the thread layout isLayout<Shape<_16,_8>>, i.e. 16x8.The k-major copies a few lines below already label the same
Shape<_16,_8>as16x8, so this corrects the m-major/n-major comments to match the code and the surrounding convention.Comment-only change; no functional impact.
Fixes #3340