Skip to content

Add code quality guidelines to AGENTS.md - #3773

Merged
timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:tmoon/agents-md-code-quality
Oct 30, 2026
Merged

timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:tmoon/agents-md-code-quality

Conversation

@timmoon10

Copy link
Copy Markdown
Member

Description

This is an attempt to avoid some annoying habits in agent-generated code.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Add code quality guidelines to AGENTS.md

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10
timmoon10 requested review from ksivaman and ptrendx October 29, 2026 00:00
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The documentation change appears safe to merge.

Summary

Adds code quality guidelines to AGENTS.md.

  • Contributors and coding agents now have guidance for writing readable, focused code.

Reviews (1) · Last reviewed commit: "Add code quality guidelines to AGENTS.md" · Reviewed by Greptile

Comment thread AGENTS.md
Comment on lines +400 to +402
- Extend existing infrastructure rather than building parallel systems.
For example, add cases to an existing test suite instead of creating
a new test file for each change.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ksivaman ksivaman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge but I'm wondering if it would make a difference.

Do you have any example before and after with this? This repo has defined a lot of predefined skills, including for code review and quality here, perhaps it is also something to look at.

@timmoon10
timmoon10 merged commit 43f61f7 into NVIDIA:main Oct 30, 2026
13 checks passed
@timmoon10
timmoon10 deleted the tmoon/agents-md-code-quality branch October 30, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants