Clarify gateway and middleware timeout settings - #34
Merged
Conversation
Documentation previewThe preview has been removed. |
Collaborator
Author
Panel review notesResult: clean after two review rounds. Reviewed target: Reproduce with: git diff da6f31d1d89a7c2d0dfba8504c7132dadffd7e8b...6fbcb36813b209dd30518fc9ed436f58ff3f7183 -- projects/egress-gateThree independent reviewers covered:
Accepted findings fixed:
Rejected low-severity suggestions:
Validation:
The second panel pass reported no remaining accepted findings. |
johnnygreco
marked this pull request as ready for review
August 7, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout_middleware_processingtimeout_gateway_ceiling--timeout-secondswith concise duration-based--timeoutvalues such as10sand500msWhy
The previous naming made the gateway's maximum allowed timeout easy to confuse
with the middleware's actual processing timeout. This change makes the two
settings explicit while keeping the CLI concise:
The registration command writes a 30s gateway ceiling, so any supported
serve --timeoutvalue is effective unless an operator lowers the gatewayceiling.
No protobuf or generated binding files are changed.
Validation
make check— 268 tests passed on the isolated commitpython3 tests/test_render_dev_notes.pyscripts/build-docs.sh