build(core): require cryptography 48 - #2149
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⛔ Files ignored due to path filters (86)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (86)
📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test 6bdf25c |
|
/ok to test bc55721 |
|
@Salonijain27 Output of |
bc55721 to
9b769a1
Compare
|
Rebuilt on current |
|
/ok to test 9b769a1 |
9b769a1 to
11c683b
Compare
|
Sorry, I missed a file 🤦♂️ Apologies for the noise. Pushed one more time... |
|
@DABH so we don't waste another cycle... Please invoke and share the output of: |
Also ran and looks clean... |
|
Thank you! |
|
/ok to test 11c683b |
Salonijain27
left a comment
There was a problem hiding this comment.
Approved from a dependency point of view
|
@DABH pre-commit checks are still failing |
|
@willkill07 Yep I realized the issue - work laptop had a secret filter going on that was (silently) preventing interactions with files named openclaw. Go figure. Going to update the PR on my home machine and should be good then. Apologies for all the hassle on what should have been a trivial PR!... |
Cryptography wheels below 48.0.1 bundle a vulnerable statically linked OpenSSL (GHSA-537c-gmf6-5ccf); the previous cryptography>=46.0.6,<47 pin made the patched wheels unresolvable for every environment that includes the toolkit. Require the patched line outright (floor raised per review) and regenerate the lock files, which now resolve cryptography 48.0.1 throughout. oci, langchain-litellm, and pyopenssl move to the first releases permitting 48.x; the redis package lock resolves core from the package registry and is unaffected. Signed-off-by: David Hyde <DABH@users.noreply.github.com>
11c683b to
075dae2
Compare
|
@willkill07 , ok, 87 files not 86 changed now, I see openclaw package's uv lock was successfully regenerated. Should be good to go now. Thank you again! |
|
/ok to test 075dae2 |
Description
Cryptography wheels below 48.0.1 bundle a vulnerable statically linked OpenSSL (GHSA-537c-gmf6-5ccf, high severity). Core's
cryptography>=46.0.6,<47pin makes the patched wheels unresolvable for every environment that includes the toolkit, so downstream integrations (like what I'm building right now) can't remediate the advisory.cryptography>=48.0,<49(floor raised to the patched line per review).oci(→ 2.183.0),langchain-litellm(→ 0.6.6), andpyopenssl(→ 26.2.0) move to the first releases permitting 48.x, since their previously locked versions also capped cryptography below 47.packages/nvidia_nat_redis/uv.lockresolves core from the registry rather than the workspace and is unaffected.Note:
authlib(core's direct cryptography consumer) declares no cryptography bound at the locked 1.7.2, so core's pin is the binding constraint (this change alone is sufficient).No existing issue; happy to file a tracking issue if the team prefers one.
Testing
On Python 3.13.12 / uv 0.9.28 (the pinned dev version):
uv lockre-run across all 87 projects is a strict no-op after this PR's regeneration. (Test results below were produced under the initial commit and re-verified after the floor bump: the resolved set is identical, cryptography 48.0.1 throughout.)pytest packages/nvidia_nat_core— 2793 passed, 54 skipped (the suite's default skips).tests/nat/authentication+tests/nat/front_ends— 396 passed, 3 skipped;nvidia_nat_a2a(OAuth middleware exercises cryptography key generation and PEM serialization directly) — 63 passed.python ci/scripts/copyright.py --verify-apache-v2— passed.By Submitting this PR I confirm: