Fix -y short flag collision between --yaml and --yes (#559) - #561
Fix -y short flag collision between --yaml and --yes (#559)#561CodersAcademy006 wants to merge 3 commits into
Conversation
RunContext.cli_command bound -y to both --yaml and --yes/--no-confirm, so Click emitted a warning on every invocation. Drop -y from --yaml, keeping -y as the conventional alias for --yes. Closes NVIDIA-NeMo#559 Signed-off-by: Srijan Upadhyay <srjnupadhyay@gmail.com>
|
@ko3n1g @chtruong814 could one of you take a look at this and at #562? Both have been open since July 14 with no reviewer assigned, and the original cc to @hemildesai and @marcromeyn was not picked up. This one is a single line in |
|
PR #561 — needs attention |
|
@CodersAcademy006 could you take a look at #561 (comment) please? |
|
Hey @ko3n1g Fixed all three blockers. Removed -y from yaml option in api.py line 894, updated docs at 349, added TestShortFlagCollision regression tests to verify -y works for skip_confirmation and yaml has no short flag. Ready to merge. |
- Remove -y short flag from --yaml option documentation - Add TestShortFlagCollision regression test suite with three tests: - Verify --yaml flag works independently - Verify -y correctly triggers --yes/--no-confirm - Ensure no Click warnings in help output Fixes NVIDIA-NeMo#559
Summary
In
RunContext.cli_command(nemo_run/cli/api.py), both--yamland--yes/--no-confirmclaimed the short flag-y, so Click emitted a warning on every invocation. This drops-yfrom--yamland keeps it as the conventional alias for--yes.Closes #559
cc @hemildesai @marcromeyn