Skip to content

feat: Add recipes - #3549

Merged
yfw merged 12 commits into
mainfrom
yifu/lightning35
Aug 11, 2026
Merged

yfw merged 12 commits into
mainfrom
yifu/lightning35

Conversation

@yfw

@yfw yfw commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add nemotron recipes and scripts

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

yfw added 2 commits August 7, 2026 12:13
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw
yfw requested review from a team as code owners August 8, 2026 01:47
@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Aug 8, 2026
@yfw yfw added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Aug 8, 2026
yfw added 7 commits August 7, 2026 18:49
Add the required val_start_at setting while preserving the previous validation behavior. Rely on GRPO's current KL-zero auto-configuration for skipping reference-policy logprobs.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Run GenRM and NL2Bash through the generic external Gym vLLM pool interface while keeping the safety judge local. Update the validated node layout, mounts, backend settings, and user guide for the production Nano 3.5 RLVR launch.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw
yfw force-pushed the yifu/lightning35 branch from 12c2228 to 2ee35b4 Compare August 8, 2026 02:04
@yfw

yfw commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2ee35b4

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>

@macandro96 macandro96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with a team of six agents (four independent finders across the guide, config, launcher, and tests; two adversarial verifiers that re-derived every claim from source).

Nice work on this — the recipe is complete and self-consistent where it counts. Things that came back clean: all 33 env.nemo_gym.config_paths resolve at the pinned Gym SHA; the 86-node / 344-GPU topology sums correctly and matches the launcher defaults, the YAML header, and both sbatch het components; batch-size and parallelism divisibility all hold (8192 = 512x16, DP=8, EP=16 valid); max_total_sequence_length is consistent across training, generation, and max_model_len; the sbatch argv is well-formed under a stubbed submission; and there are no secrets or internal hostnames. Adding launcher dry-run tests is a genuine improvement over the ultra_launch.sh precedent, which has none.

Nothing below is blocking — some suggestions / nits.

Generated by Claude Code

Comment thread examples/nemo_gym/nemotron-3.5-lightning/rlvr.yaml
Comment thread docs/guides/nemotron-3.5-lightning.md
Comment thread examples/nemo_gym/nemotron-3.5-lightning/rlvr.yaml Outdated
Comment thread docs/guides/nemotron-3.5-lightning.md
yfw added 2 commits August 10, 2026 13:46
Use vLLM's built-in Nemotron parser, configure Gym proxy workers, and remove unsupported MoE dispatcher options. Document the primary launcher overrides and update launcher coverage.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw

yfw commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test cf68648

@yfw
yfw merged commit 0ded4a9 into main Aug 11, 2026
83 checks passed
@yfw
yfw deleted the yifu/lightning35 branch August 11, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants