feat: Add recipes - #3549
feat: Add recipes#3549
Conversation
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Add the required val_start_at setting while preserving the previous validation behavior. Rely on GRPO's current KL-zero auto-configuration for skipping reference-policy logprobs. Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Run GenRM and NL2Bash through the generic external Gym vLLM pool interface while keeping the safety judge local. Update the validated node layout, mounts, backend settings, and user guide for the production Nano 3.5 RLVR launch. Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
|
/ok to test 2ee35b4 |
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
macandro96
left a comment
There was a problem hiding this comment.
Reviewed with a team of six agents (four independent finders across the guide, config, launcher, and tests; two adversarial verifiers that re-derived every claim from source).
Nice work on this — the recipe is complete and self-consistent where it counts. Things that came back clean: all 33 env.nemo_gym.config_paths resolve at the pinned Gym SHA; the 86-node / 344-GPU topology sums correctly and matches the launcher defaults, the YAML header, and both sbatch het components; batch-size and parallelism divisibility all hold (8192 = 512x16, DP=8, EP=16 valid); max_total_sequence_length is consistent across training, generation, and max_model_len; the sbatch argv is well-formed under a stubbed submission; and there are no secrets or internal hostnames. Adding launcher dry-run tests is a genuine improvement over the ultra_launch.sh precedent, which has none.
Nothing below is blocking — some suggestions / nits.
Generated by Claude Code
Use vLLM's built-in Nemotron parser, configure Gym proxy workers, and remove unsupported MoE dispatcher options. Document the primary launcher overrides and update launcher coverage. Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
|
/ok to test cf68648 |
What does this PR do ?
Add nemotron recipes and scripts
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information