Conversation
…extra resolution uv 0.11.x generates revision 4 lockfiles when dependencies change (e.g. on a MBridge bump). In revision 4, `uv sync --frozen --extra X` fails with "Extra 'X' is not defined in the project's optional-dependencies table" because uv resolves the sync target against the first workspace member (nemo-gym) rather than the CWD package (nemo-rl). Adding `--package nemo-rl` to all uv sync calls makes the workspace package selection explicit, fixing the mbridge bump CI automation. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
Contributor
Author
|
/claude review |
Contributor
Author
|
Closing — needs further review on whether --package nemo-rl skips nemo-gym base dependency installation in the container. Root cause and fix documented in research and investigation notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
uv sync --frozen --extra Xfailing with:Root cause
uv 0.11.x generates revision 4 lockfiles when packages actually change (e.g. during an automated MBridge bump). In revision 4,
uv sync --frozen --extra Xwithout an explicit--packageflag resolves the sync target against the first workspace member (nemo-gym) rather than the CWD package (nemo-rl). Sincenemo-gymhas no extras, any--extra Xcall fails.The committed
uv.lockonmainis revision 3 (generated when nothing changes) and works fine. But as soon as any dependency changes anduv lockruns, the lockfile becomes revision 4 and all--extra Xsyncs break.Fix
Add
--package nemo-rlto alluv synccalls in the hermetic build stage. This makes workspace package selection explicit regardless of lockfile revision or member ordering.Testing
Verified via the nemo-ci mbridge bump automation (
build-NeMo-RL-mbridge-bumpjob) which exercises exactly this code path on a freshly-relocked bump branch.