Repository navigation
docs(notifications-category-sync): require marketing section to stay last on mobile - #196
Merged
baptiste-marchand merged 1 commit intoOct 13, 2026
Conversation
…last on mobile The 'Updates and rewards' (marketing) settings row must always render last in metamask-mobile's notification settings. New categories are inserted above it. This is now enforced in the mobile repo by an ordering test in notificationSettingsSections.test.ts, so a misplaced registry entry fails CI.
baptiste-marchand
marked this pull request as ready for review
October 12, 2026 09:53
zelkibuilds
approved these changes
Oct 12, 2026
baptiste-marchand
deleted the
docs/notifications-category-order-marketing-last
branch
October 13, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
notifications-category-syncskill's metamask-mobile overlay describes how to register a new section inNOTIFICATION_SETTINGS_SECTIONS, but it did not state where the new entry goes. On mobile, notification settings rows have a product-mandated order in which "Updates and rewards" (marketing) must always render last — new categories are inserted above it, never appended after it.This PR adds that rule to step 5 (Registry) of
domains/platform/skills/notifications-category-sync/repos/metamask-mobile.md, and points to the ordering test (notificationSettingsSections.test.ts) that now asserts the full section order (marketing last) in the mobile repo, so a misplaced entry fails CI.The rule is mobile-specific (the parent
skill.mdis client-agnostic), which is why it lives in the repo overlay rather than the parent skill.Corresponding mobile-repo change (section reorder + ordering test) to be linked once its PR is opened.
Type of Change
Skill Details (if adding a new skill)
N/A — update to an existing skill overlay.
Checklist
Testing
The updated step was followed end-to-end in
metamask-mobileto reorder its notification settings sections (Wallet activity, Trading activity, Trading signals, Price alerts, Agent wallet, Updates and rewards last). The ordering test added in the mobile repo passes, and lint / type check are clean; a misplaced registry entry now fails CI as the skill states.Additional Context
Section order in question (mobile settings screen):