Repository navigation
ci: pin Node.js to 26.12.1 - #87
Conversation
GitHub Actions and CircleCI were on Node 20 and 18, which are EOL and were not patched for CVE-2026-111497. Pin .nvmrc to 24.22.1 instead of lts/* so it does not move to Node 26. Co-authored-by: Cursor <cursoragent@cursor.com>
CI was on Node 18 and 20, which have no CVE-2026-111497 fix. Try the newest patched release instead of 24 LTS. Co-authored-by: Cursor <cursoragent@cursor.com>
Node 26.12.1 fails yarn install because yargs uses require under ESM. Co-authored-by: Cursor <cursoragent@cursor.com>
allow-scripts crashes on Node 26 because yargs 17.7.2's require entry is ESM. Resolve that pin to 17.7.3. Node 26.12.1 does not ship corepack, so install it before Yarn. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning MetaMask internal reviewing guidelines:
|
GitHub Actions already installs on 26.12.1. Keep the local pin and the CircleCI image on the same release. Co-authored-by: Cursor <cursoragent@cursor.com>
That release depends on yargs 17.7.3, so the install hook no longer needs a yargs resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
GitHub Actions were on Node 20, CircleCI was on
cimg/node:18.13.0-browsers, and.nvmrctrackedlts/*. Node 18 and 20 are EOL and were not patched for CVE-2026-111497.This pins Node.js 26.12.1 in
.nvmrc, the Android, iOS, and Detox GitHub Actions workflows, and the CircleCI image (cimg/node:26.12.1-browsers). Node 26 entered Active LTS on 28 October 2026.Node 26.12.1 does not ship Corepack, so those workflows install it with
npm install -g corepackbeforecorepack enable.@lavamoat/allow-scripts3.x depends on yargs 17.7.2, whoserequireentry is ESM and crashesyarn installon Node 26. The dependency is pinned to5.1.0, which depends on yargs 17.7.3.Refs: MCWP-1125
https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
https://github.com/nodejs/Release/blob/main/README.md