Add functionality to import an official configuration - #101
Conversation
|
Thanks! I've been meaning to add an interface for this. A hierarchical config selector — basically a file navigator for the Configurations repo — seemed the right way to go. I'll have a look at your implementation and do some UI refinements. I will soon have an "import" function that converts older configs to current version configs, so I'll do a little adjustment of terminology to avoid the lexical collision. |
|
Sounds good - the selection of the correct config just leverages quick picks in VS code, seemed entirely easy! the next step after this would be to allow users create a pull request in MarlinFirmware/Configurations for their customisations... An idea for a different day :) |
|
First impression is that the UI for selection is really good, integrated into VSCode makes a lot of sense. I was going to build out this whole selector but there's nothing ambiguous about the simple filter field. I'll try it with older Marlin versions next. One change I'll make first is to give the panel its own tab so that it can be more easily discovered. Or I could just move the button to the ABM Config Panel. I'll explore moving the button to the Panel first and see what that does for the UX. |
69d5d74 to
08e4a27
Compare
|
Ok, I moved the button to the top next to [Monitor] and [Refresh] and added an SVG for the button. Then I modified the code to back up configs right before downloading the new ones, and if the download fails the configurations are restored from the backup folder and the folder is removed. |
f9f96b6 to
751c3a3
Compare
|
It seemed like a good idea to open and display the README file, if present, so the downloader now does that too, and it's a pretty good user experience. The only refinement I might add is an option to revert to one of the configuration backups. A small "⏪" button next to "Downloads" might work…. |
|
For simplicity I've just put "Restore: Backup Name (timestamp)" at the top when you click the "Download" button. I think this is now complete enough to merge, so I will tag and release 2.1.88 this evening. |
- Download button with tooltip - Back up current configs before download - Handle rare missing `Configuration_adv.h` - Items added to restore backups - Display README if present
Summary
This PR adds an Official Configs workflow to Auto Build Marlin so users can import a preset from MarlinFirmware/Configurations that exactly matches the local Marlin version, with a clear overwrite warning.
Why
Users need a guided way to load official example configurations without manually cloning/copying files, while understanding that local files can be overwritten.
Changes
Files Touched
UX Notes
Validation
Risk