Skip to content

MDEV-40081: Remove outdated PIC explictness #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
grooverdan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

MDEV-40081: Remove outdated PIC explictness #5250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 4 additions & 26 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,27 +57,6 @@ IF (${MAX_INDEXES} GREATER 128)
MESSAGE(FATAL_ERROR "MAX_INDEXES values greater than 128 is not supported!")
ENDIF()

IF(UNIX AND NOT APPLE)
# Note, that generally one should not change settings depending
# on CMAKE_BUILD_TYPE, because VS and Xcode configure once (with
# the empty CMAKE_BUILD_TYPE) and the build many times for
# different build types without re-running cmake!
# But we only care about WITH_PIC on Unix, where the check for
# CMAKE_BUILD_TYPE hapen to work.
IF (CMAKE_BUILD_TYPE MATCHES "Debug")
SET(WITH_PIC_DEFAULT ON)
ELSE()
SET(WITH_PIC_DEFAULT OFF)
ENDIF()
# Compiling with PIC speeds up embedded build, on PIC sensitive systems
# Predefine it to OFF in release builds, because of the performance penalty
SET(WITH_PIC ${WITH_PIC_DEFAULT} CACHE BOOL "Compile with PIC.")
MARK_AS_ADVANCED(WITH_PIC)
ENDIF()

# This is used by TokuDB only
SET(MYSQL_PROJECT_NAME_DOCSTRING "MySQL project name")

# C and C++ standards (e.g. -std=c++17)
SET(CMAKE_C_STANDARD 99)
SET(CMAKE_CXX_STANDARD 17)
Expand Down Expand Up @@ -223,10 +202,10 @@ OPTION(WITH_ASAN "Enable address sanitizer" OFF)
IF (WITH_ASAN AND NOT MSVC)
# this flag might be set by default on some OS
MY_CHECK_AND_SET_COMPILER_FLAG("-U_FORTIFY_SOURCE" DEBUG RELWITHDEBINFO)
MY_CHECK_AND_SET_COMPILER_FLAG("-fsanitize=address -fPIC"
MY_CHECK_AND_SET_COMPILER_FLAG("-fsanitize=address"
DEBUG RELWITHDEBINFO)
SET(HAVE_C_FSANITIZE ${have_C__fsanitize_address__fPIC})
SET(HAVE_CXX_FSANITIZE ${have_CXX__fsanitize_address__fPIC})
SET(HAVE_C_FSANITIZE ${have_C__fsanitize_address})
SET(HAVE_CXX_FSANITIZE ${have_CXX__fsanitize_address})
IF(HAVE_C_FSANITIZE AND HAVE_CXX_FSANITIZE)
OPTION(WITH_ASAN_SCOPE "Enable -fsanitize-address-use-after-scope" OFF)
SET(WITH_ASAN_OK 1)
Expand Down Expand Up @@ -286,7 +265,7 @@ ENDIF()

OPTION(WITH_GPROF "Enable profiling with gprof" OFF)
IF (WITH_GPROF)
MY_CHECK_AND_SET_COMPILER_FLAG("-pg -g -no-pie -fPIC")
MY_CHECK_AND_SET_COMPILER_FLAG("-pg -g")
ENDIF()

# Be nice to profilers etc
Expand All @@ -297,7 +276,6 @@ MY_CHECK_AND_SET_COMPILER_FLAG("-fno-omit-frame-pointer" RELWITHDEBINFO)
OPTION(SECURITY_HARDENED "Use security-enhancing compiler features (stack protector, relro, etc)" ON)
IF(SECURITY_HARDENED AND NOT WITH_ASAN AND NOT WITH_UBSAN AND NOT WITH_TSAN AND NOT WITH_GPROF AND NOT WITH_MSAN)
# security-enhancing flags
MY_CHECK_AND_SET_COMPILER_FLAG("-pie -fPIC")
MY_CHECK_AND_SET_LINKER_FLAG("-Wl,-z,relro,-z,now")
MY_CHECK_AND_SET_COMPILER_FLAG("-fstack-protector --param=ssp-buffer-size=4")
MY_CHECK_AND_SET_COMPILER_FLAG("-D_FORTIFY_SOURCE=2" RELEASE RELWITHDEBINFO)
Expand Down
56 changes: 20 additions & 36 deletions cmake/libutils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@
# convenience library is a static library that can be linked to shared library
# On systems that force position-independent code, linking into shared library
# normally requires compilation with a special flag (often -fPIC). To enable
# linking static libraries to shared, we compile source files that come into
# static library with the PIC flag (${CMAKE_SHARED_LIBRARY_C_FLAGS} in CMake)
# Some systems, like Windows or OSX do not need special compilation (Windows
# never uses PIC and OSX always uses it).
# linking static libraries to shared, we compile source files with a PIC
# property that cmake understands.
#
# The intention behind convenience libraries is simplify the build and to reduce
# excessive recompiles.
Expand All @@ -44,18 +42,12 @@
# library from several convenience libraries

# Important global flags
# - WITH_PIC : If set, it is assumed that everything is compiled as position
# independent code (that is CFLAGS/CMAKE_C_FLAGS contain -fPIC or equivalent)
# If defined, ADD_CONVENIENCE_LIBRARY does not add PIC flag to compile flags
#
# - DISABLE_SHARED: If set, it is assumed that shared libraries are not produced
# during the build. ADD_CONVENIENCE_LIBRARY does not add anything to compile flags
# during the build. ADD_CONVENIENCE_LIBRARY does not mark the target with the
# POSITION_INDEPENDENT_CODE property.


GET_FILENAME_COMPONENT(MYSQL_CMAKE_SCRIPT_DIR ${CMAKE_CURRENT_LIST_FILE} PATH)
IF(WIN32 OR CYGWIN OR APPLE OR WITH_PIC OR DISABLE_SHARED OR NOT CMAKE_SHARED_LIBRARY_C_FLAGS)
SET(_SKIP_PIC 1)
ENDIF()

INCLUDE(CMakeParseArguments)
# CREATE_EXPORTS_FILE (VAR target api_functions)
Expand Down Expand Up @@ -97,18 +89,15 @@ MACRO(CREATE_EXPORTS_FILE VAR TARGET API_FUNCTIONS)
ENDMACRO()


# MYSQL_ADD_CONVENIENCE_LIBRARY(name source1...sourceN)
# ADD_CONVENIENCE_LIBRARY(name source1...sourceN)
# Create static library that can be linked to shared library.
# On systems that force position-independent code, adds -fPIC or
# equivalent flag to compile flags.
MACRO(ADD_CONVENIENCE_LIBRARY)
SET(TARGET ${ARGV0})
SET(SOURCES ${ARGN})
LIST(REMOVE_AT SOURCES 0)
ADD_LIBRARY(${TARGET} STATIC ${SOURCES})
IF(NOT _SKIP_PIC)
SET_TARGET_PROPERTIES(${TARGET} PROPERTIES COMPILE_FLAGS
"${CMAKE_SHARED_LIBRARY_C_FLAGS}")
IF(NOT DISABLE_SHARED)
SET_TARGET_PROPERTIES(${TARGET} PROPERTIES POSITION_INDEPENDENT_CODE ON)
ENDIF()
ENDMACRO()

Expand Down Expand Up @@ -137,9 +126,8 @@ MACRO(MERGE_STATIC_LIBS TARGET OUTPUT_NAME LIBS_TO_MERGE)
SET(SOURCE_FILE ${CMAKE_CURRENT_BINARY_DIR}/${TARGET}_depends.c)
ADD_LIBRARY(${TARGET} STATIC ${SOURCE_FILE})
SET_TARGET_PROPERTIES(${TARGET} PROPERTIES OUTPUT_NAME ${OUTPUT_NAME})
IF(NOT _SKIP_PIC)
SET_TARGET_PROPERTIES(${TARGET} PROPERTIES COMPILE_FLAGS
"${CMAKE_SHARED_LIBRARY_C_FLAGS}")
IF(NOT DISABLE_SHARED)
SET_TARGET_PROPERTIES(${TARGET} PROPERTIES POSITION_INDEPENDENT_CODE ON)
ENDIF()

SET(OSLIBS)
Expand Down Expand Up @@ -268,22 +256,18 @@ MACRO(MERGE_LIBRARIES)
SET(LIBTYPE MODULE)
ENDIF()
# check for non-PIC libraries
IF(NOT _SKIP_PIC)
FOREACH(LIB ${LIBS})
GET_TARGET_PROPERTY(LTYPE ${LIB} TYPE)
IF(LTYPE STREQUAL "STATIC_LIBRARY")
GET_TARGET_PROPERTY(LIB_COMPILE_FLAGS ${LIB} COMPILE_FLAGS)
STRING(REPLACE "${CMAKE_SHARED_LIBRARY_C_FLAGS}"
"<PIC_FLAG>" LIB_COMPILE_FLAGS "${LIB_COMPILE_FLAGS}")
IF(NOT LIB_COMPILE_FLAGS MATCHES "<PIC_FLAG>")
MESSAGE(FATAL_ERROR
"Attempted to link non-PIC static library ${LIB} to shared library ${TARGET}\n"
"Please use ADD_CONVENIENCE_LIBRARY, instead of ADD_LIBRARY for ${LIB}"
)
ENDIF()
FOREACH(LIB ${LIBS})
GET_TARGET_PROPERTY(LTYPE ${LIB} TYPE)
IF(LTYPE STREQUAL "STATIC_LIBRARY")
GET_TARGET_PROPERTY(LIB_PIC ${LIB} POSITION_INDEPENDENT_CODE)
IF(NOT LIB_PIC)
MESSAGE(FATAL_ERROR
"Attempted to link non-PIC static library ${LIB} to shared library ${TARGET}\n"
"Please use ADD_CONVENIENCE_LIBRARY, instead of ADD_LIBRARY for ${LIB}"
)
ENDIF()
ENDFOREACH()
ENDIF()
ENDIF()
ENDFOREACH()
Comment on lines +259 to +270

@gemini-code-assist gemini-code-assist Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

On platforms like Windows (where PIC is not used) or macOS (where PIC is always enabled by default), the POSITION_INDEPENDENT_CODE target property is typically not explicitly set.

By removing the platform-skipping logic (previously handled by _SKIP_PIC), this check will run on all platforms. On Windows and macOS, GET_TARGET_PROPERTY(LIB_PIC ...) will return NOTFOUND, causing IF(NOT LIB_PIC) to evaluate to true and trigger a FATAL_ERROR during the build.

To prevent build failures on these platforms, we should skip this check on Windows, Cygwin, macOS, or when shared libraries are disabled.

    IF(NOT WIN32 AND NOT CYGWIN AND NOT APPLE AND NOT DISABLE_SHARED)
      FOREACH(LIB ${LIBS})
        GET_TARGET_PROPERTY(LTYPE ${LIB} TYPE)
        IF(LTYPE STREQUAL "STATIC_LIBRARY")
          GET_TARGET_PROPERTY(LIB_PIC ${LIB} POSITION_INDEPENDENT_CODE)
          IF(NOT LIB_PIC)
            MESSAGE(FATAL_ERROR
            "Attempted to link non-PIC static library ${LIB} to shared library ${TARGET}\n"
            "Please use ADD_CONVENIENCE_LIBRARY, instead of ADD_LIBRARY for ${LIB}"
            )
          ENDIF()
        ENDIF()
      ENDFOREACH()
    ENDIF()

CREATE_EXPORTS_FILE(SRC ${TARGET} "${ARG_EXPORTS}")
IF(NOT ARG_NOINSTALL)
ADD_VERSION_INFO(${TARGET} SHARED SRC)
Expand Down
3 changes: 2 additions & 1 deletion cmake/pcre.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ MACRO(BUNDLE_PCRE2)
"-DPCRE2_BUILD_PCRE2GREP=OFF"
"-DBUILD_SHARED_LIBS=OFF"
"-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"
"-DCMAKE_C_FLAGS=${pcre2_flags} ${PIC_FLAG}"
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
"-DCMAKE_C_FLAGS=${pcre2_flags}"
"-DCMAKE_C_FLAGS_DEBUG=${pcre2_flags_DEBUG}"
"-DCMAKE_C_FLAGS_RELWITHDEBINFO=${pcre2_flags_RELWITHDEBINFO}"
"-DCMAKE_C_FLAGS_RELEASE=${pcre2_flags_RELEASE}"
Expand Down
4 changes: 2 additions & 2 deletions cmake/plugin.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ MACRO(MYSQL_ADD_PLUGIN)
ADD_DEPENDENCIES(${target} GenError ${ARG_DEPENDS})
RESTRICT_SYMBOL_EXPORTS(${target})
IF(WITH_EMBEDDED_SERVER AND (NOT ARG_NOT_EMBEDDED))
# Embedded library should contain PIC code and be linkable
# Embedded library should be linkable
# to shared libraries (on systems that need PIC)
IF(ARG_RECOMPILE_FOR_EMBEDDED OR NOT _SKIP_PIC)
IF(ARG_RECOMPILE_FOR_EMBEDDED)
# Recompile some plugins for embedded
ADD_CONVENIENCE_LIBRARY(${target}_embedded ${SOURCES})
RESTRICT_SYMBOL_EXPORTS(${target}_embedded)
Expand Down
20 changes: 0 additions & 20 deletions configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,6 @@ INCLUDE (CheckCCompilerFlag)
INCLUDE (CheckCSourceRuns)
INCLUDE (CheckSymbolExists)


# WITH_PIC options.Not of much use, PIC is taken care of on platforms
# where it makes sense anyway.
IF(UNIX)
IF(APPLE)
# OSX executable are always PIC
SET(WITH_PIC ON)
ELSE()
OPTION(WITH_PIC "Generate PIC objects" OFF)
IF(WITH_PIC)
SET(CMAKE_C_FLAGS
"${CMAKE_C_FLAGS} ${CMAKE_SHARED_LIBRARY_C_FLAGS}")
SET(CMAKE_CXX_FLAGS
"${CMAKE_CXX_FLAGS} ${CMAKE_SHARED_LIBRARY_CXX_FLAGS}")
ENDIF()
ENDIF()
ENDIF()



# System type affects version_compile_os variable
IF(NOT SYSTEM_TYPE)
IF(PLATFORM)
Expand Down
2 changes: 1 addition & 1 deletion libmysqld/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ ENDIF()
IF(TARGET libfmt)
ADD_DEPENDENCIES(sql_embedded libfmt)
ENDIF()
TARGET_LINK_LIBRARIES(sql_embedded LINK_PRIVATE tpool ${CRC32_LIBRARY} pcre2-8)
TARGET_LINK_LIBRARIES(sql_embedded LINK_PRIVATE tpool_embedded ${CRC32_LIBRARY} pcre2-8)

# On Windows, static embedded server library is called mysqlserver.lib
# On Unix, it is libmysqld.a
Expand Down
2 changes: 1 addition & 1 deletion plugin/userstat/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/sql)

MYSQL_ADD_PLUGIN(USERSTAT userstat.cc MANDATORY)
MYSQL_ADD_PLUGIN(USERSTAT userstat.cc MANDATORY RECOMPILE_FOR_EMBEDDED)

2 changes: 1 addition & 1 deletion storage/csv/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA

SET(CSV_SOURCES ha_tina.cc ha_tina.h transparent_file.cc transparent_file.h)
MYSQL_ADD_PLUGIN(csv ${CSV_SOURCES} STORAGE_ENGINE MANDATORY)
MYSQL_ADD_PLUGIN(csv ${CSV_SOURCES} STORAGE_ENGINE MANDATORY RECOMPILE_FOR_EMBEDDED)
2 changes: 1 addition & 1 deletion storage/sequence/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
MYSQL_ADD_PLUGIN(sequence sequence.cc STORAGE_ENGINE DEFAULT)
MYSQL_ADD_PLUGIN(sequence sequence.cc STORAGE_ENGINE DEFAULT RECOMPILE_FOR_EMBEDDED)
61 changes: 44 additions & 17 deletions tpool/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,44 @@ SET(COMMON_SOURCES
wait_notification.cc
)

IF(WITH_EMBEDDED_SERVER)
LIST(APPEND tpool_list tpool tpool_embedded)
LIST(APPEND tpool_common_list tpool_common tpool_common_embedded)
ELSE()
SET(tpool_list tpool)
SET(tpool_common_list tpool_common)
ENDIF()

IF(NOT CMAKE_SYSTEM_NAME STREQUAL "Linux")
ADD_LIBRARY(tpool OBJECT ${COMMON_SOURCES} aio_simulated.cc)
IF(WIN32)
TARGET_SOURCES(tpool PRIVATE tpool_win.cc aio_win.cc)
ADD_LIBRARY(tpool OBJECT ${COMMON_SOURCES} aio_simulated.cc)
IF(WITH_EMBEDDED_SERVER)
ADD_CONVENIENCE_LIBRARY(tpool_embedded ${COMMON_SOURCES} aio_simulated.cc)
ENDIF()
TARGET_INCLUDE_DIRECTORIES(tpool PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/include)
FOREACH(t ${tpool_list})
IF(WIN32)
TARGET_SOURCES(${t} PRIVATE tpool_win.cc aio_win.cc)
ENDIF()
TARGET_INCLUDE_DIRECTORIES(${t} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/include)
ENDFOREACH()
ADD_LIBRARY(tpool_min ALIAS tpool)
ELSE() # Linux
ADD_LIBRARY(tpool_common OBJECT ${COMMON_SOURCES})
# Ensure that aiocb used as opaque in common code, or ABI will be broken
TARGET_COMPILE_DEFINITIONS(tpool_common PRIVATE -DTPOOL_OPAQUE_AIOCB)
TARGET_INCLUDE_DIRECTORIES(tpool_common PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/include)
ADD_LIBRARY(tpool STATIC aio_linux.cc aio_simulated.cc)
ADD_LIBRARY(tpool_common OBJECT ${COMMON_SOURCES})
IF(WITH_EMBEDDED_SERVER)
ADD_CONVENIENCE_LIBRARY(tpool_embedded aio_linux.cc aio_simulated.cc)
ADD_CONVENIENCE_LIBRARY(tpool_common_embedded OBJECT ${COMMON_SOURCES})

@gemini-code-assist gemini-code-assist Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The ADD_CONVENIENCE_LIBRARY macro hardcodes the creation of a STATIC library and does not support the OBJECT keyword.

Passing OBJECT as the second argument to ADD_CONVENIENCE_LIBRARY will cause CMake to treat "OBJECT" as a source file name rather than a library type. This will result in a build failure because CMake will look for a source file named OBJECT (e.g., OBJECT.cc or OBJECT.cpp) which does not exist.

The OBJECT keyword should be removed.

    ADD_CONVENIENCE_LIBRARY(tpool_common_embedded ${COMMON_SOURCES})

ENDIF()
FOREACH(t ${tpool_common_list})
# Ensure that aiocb used as opaque in common code, or ABI will be broken
TARGET_COMPILE_DEFINITIONS(${t} PRIVATE -DTPOOL_OPAQUE_AIOCB)
TARGET_INCLUDE_DIRECTORIES(${t} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/include)
ENDFOREACH()

TARGET_LINK_LIBRARIES(tpool PUBLIC tpool_common)
IF(WITH_EMBEDDED_SERVER)
TARGET_LINK_LIBRARIES(tpool_embedded PUBLIC tpool_common_embedded)
ENDIF()

OPTION(WITH_URING "Require that io_uring be used" OFF)
OPTION(WITH_LIBAIO "Require that libaio is used" OFF)
IF(WITH_URING)
Expand All @@ -34,11 +57,13 @@ ELSE() # Linux
FIND_PACKAGE(URING QUIET ${URING_REQUIRED})
IF(URING_FOUND)
SET(URING_FOUND ${URING_FOUND} PARENT_SCOPE)
TARGET_COMPILE_DEFINITIONS(tpool PUBLIC "-DHAVE_URING")
TARGET_LINK_LIBRARIES(tpool PRIVATE ${URING_LIBRARIES})
TARGET_INCLUDE_DIRECTORIES(tpool PUBLIC ${URING_INCLUDE_DIRS})
TARGET_SOURCES(tpool PRIVATE aio_liburing.cc)
ADD_DEPENDENCIES(tpool GenError)
FOREACH(t ${tpool_list})
TARGET_COMPILE_DEFINITIONS(${t} PUBLIC "-DHAVE_URING")
TARGET_LINK_LIBRARIES(${t} PRIVATE ${URING_LIBRARIES})
TARGET_INCLUDE_DIRECTORIES(${t} PUBLIC ${URING_INCLUDE_DIRS})
TARGET_SOURCES(${t} PRIVATE aio_liburing.cc)
ADD_DEPENDENCIES(${t} GenError)
ENDFOREACH()
SET(CMAKE_REQUIRED_INCLUDES_SAVE ${CMAKE_REQUIRED_INCLUDES})
SET(CMAKE_REQUIRED_LIBRARIES_SAVE ${CMAKE_REQUIRED_LIBRARIES})
SET(CMAKE_REQUIRED_INCLUDES ${URING_INCLUDE_DIRS})
Expand All @@ -53,10 +78,12 @@ ELSE() # Linux

FIND_PACKAGE(LIBAIO QUIET ${LIBAIO_REQUIRED})
IF(LIBAIO_FOUND)
TARGET_COMPILE_DEFINITIONS(tpool PUBLIC "-DHAVE_LIBAIO")
TARGET_INCLUDE_DIRECTORIES(tpool PUBLIC ${LIBAIO_INCLUDE_DIRS})
TARGET_LINK_LIBRARIES(tpool PRIVATE ${LIBAIO_LIBRARIES})
TARGET_SOURCES(tpool PRIVATE aio_libaio.cc)
FOREACH(t ${tpool_list})
TARGET_COMPILE_DEFINITIONS(${t} PUBLIC "-DHAVE_LIBAIO")
TARGET_INCLUDE_DIRECTORIES(${t} PUBLIC ${LIBAIO_INCLUDE_DIRS})
TARGET_LINK_LIBRARIES(${t} PRIVATE ${LIBAIO_LIBRARIES})
TARGET_SOURCES(${t} PRIVATE aio_libaio.cc)
ENDFOREACH()
ENDIF()

IF(LIBAIO_FOUND OR URING_FOUND)
Expand Down