MDBF-1200: Implement OldBuildCanceller#955
Merged
Merged
Conversation
Collaborator
Author
|
Not urgent to review, I am planning to release it in dry-run mode after the April server release. |
RazvanLiviuVarzaru
force-pushed
the
MDBF-1200
branch
from
6699ba4 to
7c310d2
Compare
RazvanLiviuVarzaru
force-pushed
the
MDBF-1200
branch
2 times, most recently
from
14b8cae to
9d32802
Compare
RazvanLiviuVarzaru
requested review from
fauust and
grooverdan
and removed request for
fauust and
grooverdan
Collaborator
Author
|
Ready for review |
grooverdan
approved these changes
Jun 5, 2026
grooverdan
left a comment
grooverdan
left a comment
Member
There was a problem hiding this comment.
Worked last I saw it in action.
| CancelDuplicateBuildRequests(buildbot_base_url=os.environ.get("BUILDMASTER_URL")) | ||
| ) | ||
|
|
||
| f_tarball.addStep( |
Member
There was a problem hiding this comment.
I notice this is beginning of steps.
Is a duplicate step of this at the end of the tarball build providing an extra minute window check useful?
Collaborator
Author
There was a problem hiding this comment.
Not necessarily, same branch tarballs are always 1 minute apart as per treeStableTimer=60,
so the newest tarball will either:
- cancel the other tarball immediately OR
- if the older tarball already exited, will cancel its child builds.
Any corner case you have in mind?
Make tarball-docker cancel older queued or running build requests for the same branch. This ensures that builds for older commits on the same branch are cancelled, so only one commit per branch is built at a time.
RazvanLiviuVarzaru
force-pushed
the
MDBF-1200
branch
from
9d32802 to
a5646ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make tarball-docker cancel older queued or running build requests for the same branch.
This ensures that builds for older commits on the same branch are cancelled, so only one commit per branch is built at a time.