Repository navigation
Recognize CrDB invalid-cached-query errors, not just PG ones - #1408
Open
charles-dyfis-net wants to merge 1 commit into
Open
charles-dyfis-net wants to merge 1 commit into
charles-dyfis-net wants to merge 1 commit into
Conversation
CockroachDB returns "cached plan must not change result type" with SQLSTATE 0A000 but _without_ the `server_source_function` matched to recognize this same error when returned from PostgreSQL. This has resulted in `FeatureNotSupportedError` being raised instead of the intended `InvalidCachedStatementError`; without the correct error message, SQLAlchemy can't discard invalidated statement cache entries.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CockroachDB returns "cached plan must not change result type" with SQLSTATE 0A000 but without the
server_source_functionmatched to recognize this same error when returned from PostgreSQL.This has resulted in
FeatureNotSupportedErrorbeing raised instead of the intendedInvalidCachedStatementError; without the correct error message, SQLAlchemy can't discard invalidated statement cache entries.