chore: 移除 llm 模块并修复潜在的构建问题 - #3
Merged
Merged
Conversation
…anup deprecated aliases
There was a problem hiding this comment.
🟡 Changes recommended
The tar fallback permits path traversal, and PPOCRv5/v6 still overwrite custom recognizer settings through PPOCRv4.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the deprecated LLM service, modernizes OCR pipelines, and simplifies CPU-focused build packaging.
Changes:
- Deletes the complete legacy LLM client/server stack.
- Refactors PPOCRv5/v6 and removes deprecated aliases.
- Hardens and simplifies build/package configuration.
File summaries
| File | Description |
|---|---|
services/llm/server/server/utils.py |
Removes LLM server utilities. |
services/llm/server/server/triton_server.py |
Removes Triton server. |
services/llm/server/server/triton_server_helper.py |
Removes health checker. |
services/llm/server/server/http_server/app.py |
Removes HTTP application. |
services/llm/server/server/http_server/api.py |
Removes HTTP API. |
services/llm/server/server/http_server/adapter_openai.py |
Removes OpenAI adapter. |
services/llm/server/server/http_server/__init__.py |
Removes HTTP package. |
services/llm/server/server/engine/token_processor.py |
Removes token processor. |
services/llm/server/server/engine/task_queue_manager.py |
Removes task queue. |
services/llm/server/server/engine/resource_manager.py |
Removes resource manager. |
services/llm/server/server/engine/infer.py |
Removes inference runner. |
services/llm/server/server/engine/engine.py |
Removes LLM engine. |
services/llm/server/server/engine/config.py |
Removes engine configuration. |
services/llm/server/server/engine/__init__.py |
Removes engine package. |
services/llm/server/server/data/processor.py |
Removes data processor. |
services/llm/server/server/data/__init__.py |
Removes data package. |
services/llm/server/server/checker.py |
Removes request validation. |
services/llm/server/server/__init__.py |
Removes server package. |
services/llm/server/scripts/stop_server.sh |
Removes shutdown script. |
services/llm/server/scripts/start_server.sh |
Removes startup script. |
services/llm/server/requirements.txt |
Removes server dependencies. |
services/llm/server/config/config.pbtxt |
Removes Triton model configuration. |
services/llm/requirements-dev.txt |
Removes development dependencies. |
services/llm/README.md |
Removes LLM overview. |
services/llm/docs/FastDeploy_usage_tutorial.md |
Removes deployment tutorial. |
services/llm/dockerfiles/Dockerfile_serving_cuda123_cudnn9 |
Removes CUDA 12.3 image. |
services/llm/dockerfiles/Dockerfile_serving_cuda118_cudnn8 |
Removes CUDA 11.8 image. |
services/llm/client/setup.py |
Removes client packaging. |
services/llm/client/requirements.txt |
Removes client dependencies. |
services/llm/client/README.md |
Removes client documentation. |
services/llm/client/fastdeploy_client/utils.py |
Removes client utilities. |
services/llm/client/fastdeploy_client/message.py |
Removes chat messages. |
services/llm/client/fastdeploy_client/command.py |
Removes client CLI. |
services/llm/client/fastdeploy_client/chatbot.py |
Removes chatbot client. |
services/llm/client/fastdeploy_client/__init__.py |
Removes client package. |
services/llm/.dockerignore |
Removes LLM Docker exclusions. |
scripts/build.py |
Simplifies targets and archive handling. |
fastdeploy/vision/ocr/ppocr/ppocr_v6.h |
Declares PPOCRv6 implementation externally. |
fastdeploy/vision/ocr/ppocr/ppocr_v6.cc |
Implements PPOCRv6 constructors and cloning. |
fastdeploy/vision/ocr/ppocr/ppocr_v5.h |
Declares PPOCRv5 implementation externally. |
fastdeploy/vision/ocr/ppocr/ppocr_v5.cc |
Implements PPOCRv5 constructors and cloning. |
fastdeploy/runtime/backends/ort/option.h |
Documents callback takeover semantics. |
cmake/onnxruntime.cmake |
Removes obsolete ORT acquisition logic. |
cmake/config_cpack.cmake |
Removes obsolete CPack configuration. |
bindings/python/fastdeploy/vision/ocr/ppocr/__init__.py |
Removes legacy Python OCR aliases. |
bindings/c_api/fastdeploy_capi/vision/types_internal.h |
Removes unused v5/v6 C wrappers. |
bindings/c_api/CMakeLists.txt |
Uses stable list-directory paths. |
.github/workflows/build.yml |
Labels builds as CPU-only. |
Review details
- Files reviewed: 48/48 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 摘要
移除已弃用的 LLM 服务和旧版 OCR 别名,同时加强构建和打包配置。
Bug 修复:
增强功能:
构建:
杂项:
Original summary in English
Sourcery 摘要
移除已弃用的 LLM 和 OCR 兼容组件,同时强化构建与打包流程,并保留可配置的 OCR 和运行时行为。
错误修复:
增强功能:
构建:
CI:
维护:
Original summary in English
Summary by Sourcery
Remove deprecated LLM and OCR compatibility components while hardening the build and packaging workflow and preserving configurable OCR and runtime behavior.
Bug Fixes:
Enhancements:
Build:
CI:
Chores: