Skip to content

Show existing tags when tagging images - #4612

Merged
ildyria merged 3 commits into
LycheeOrg:masterfrom
jphuguet:feat/show-existing-tags-while-tagging
Aug 14, 2026
Merged

Show existing tags when tagging images#4612
ildyria merged 3 commits into
LycheeOrg:masterfrom
jphuguet:feat/show-existing-tags-while-tagging

Conversation

@jphuguet

@jphuguet jphuguet commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Displays the tags currently associated with the images when adding tags.
If multiple images are selected, the tags on each image are displayed while the tags on certain images are listed in parentheses.

Summary by CodeRabbit

  • New Features
    • Photo-tagging dialogs now show tags already applied to selected photos.
    • Tags shared across all selected photos are separated from tags applied only to some photos.
    • Existing tags are deduplicated and alphabetically sorted for easier review.
    • Guidance clarifies when displayed tags apply only to part of the selection.
  • Localization
    • Added translated labels and guidance for existing and partially applied tags across supported languages.

@jphuguet
jphuguet requested a review from a team as a code owner August 14, 2026 13:41
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 48092dcc-5f33-43f5-b50b-52226de9bb5d

📥 Commits

Reviewing files that changed from the base of the PR and between ca64707 and ed19a83.

📒 Files selected for processing (2)
  • resources/js/v7/components/forms/photo/PhotoTagDialog.vue
  • resources/js/v8/components/forms/photo/PhotoTagDialog.vue
🚧 Files skipped from review as they are similar to previous changes (2)
  • resources/js/v8/components/forms/photo/PhotoTagDialog.vue
  • resources/js/v7/components/forms/photo/PhotoTagDialog.vue

📝 Walkthrough

Walkthrough

The photo tag dialogs now derive common and partial tags from selected photos. Both Vue dialog versions display these tags with shared styling, and 23 locale files provide the new labels and guidance.

Changes

Existing photo tag display

Layer / File(s) Summary
Common and partial tag derivation
resources/js/composables/tags/existingTags.ts
useExistingTags selects target photos, deduplicates and sorts tags, separates common and partial tags, and exposes hasExistingTags.
Dialog rendering and localization
resources/js/v7/components/forms/photo/PhotoTagDialog.vue, resources/js/v8/components/forms/photo/PhotoTagDialog.vue, lang/*/dialogs.php
Both dialogs render existing tags and partial tags in parentheses. Locale files define existing_tags and partial_tags_info strings.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to ed19a

This localized UI change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Poem

A rabbit checks the tags in line,
Common carrots sort out fine.
Partial leaves wear parentheses,
Two dialogs show the difference.
Local words now greet the view.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ildyria
ildyria merged commit b810668 into LycheeOrg:master Aug 14, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants