feat: changed all Array.map(Array.range to Array.mapRange on all GetMatchGroupCopyPaste - #8081
Open
steve020607 wants to merge 1 commit into
Open
feat: changed all Array.map(Array.range to Array.mapRange on all GetMatchGroupCopyPaste#8081steve020607 wants to merge 1 commit into
steve020607 wants to merge 1 commit into
Conversation
…atchGroupCopyPaste
Collaborator
Author
|
weird error, idk what went wrong |
hjpalpha
reviewed
Sep 11, 2026
| ---@return table | ||
| function WikiCopyPaste.getStart(template, id, modus, args) | ||
| args.namedMatchParams = false | ||
| args.headersUpTop = Logic.readBool(Logic.emptyOr(args.headersUpTop, true)) |
Collaborator
There was a problem hiding this comment.
possible solution to shut up the anno warning:
args.headersUpTop = Logic.nilOr(Logic.readBoolOrNil(args.headersUpTop), true)
Collaborator
that check checks all annotations in changed files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
well pretty much explain by the title
changed all the usage of
Array.map(Array.rangetoArray.mapRangeon the GetMatchGroupCopyPaste/Wiki.luaHow did you test this change?
should be trivial enough though? i can try to test it