fix: use torch padding for kornia 0.8 compatibility - #508
Open
Nianze Wu (wunianze666-netizen) wants to merge 1 commit into
Open
fix: use torch padding for kornia 0.8 compatibility#508Nianze Wu (wunianze666-netizen) wants to merge 1 commit into
Nianze Wu (wunianze666-netizen) wants to merge 1 commit into
Conversation
Author
|
Revalidated this against current master (ac4d998) and the official Kornia 0.8.3 wheel: pyramid.py no longer exports pad, while the repository still imports it. This PR remains a focused two-call replacement using the already imported torch.nn.functional module. A maintainer review would be appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padfrom Kornia's pyramid moduletorch.nn.functional.pad()for the existing reflect-padding pathsProblem
Kornia 0.8.3 no longer exports
padfromkornia.geometry.transform.pyramid, so the current import prevents the node module from loading. PyTorch's functionalpadprovides the same padding operation already used here and avoids relying on Kornia's former internal re-export.Validation
kornia-0.8.3-py3-none-any.whl:pyramid.pyhas no exportedpadfunction and its__all__excludespadmaster(ac4d998); it still imports the removed symbolpy -m py_compile pyramid_blending.pygit diff --check