storage: fail fast on foreign rel traversal; exclude scan-backed rels from CountRelTable - #844
Merged
Conversation
… from CountRelTable MATCH traversal over a foreign-backed rel table (RelGroupCatalogEntry with a scan function, e.g. duckdb/pg_client auto-detected rel_* tables) cannot work yet: the extend pipeline expects internal node IDs while the scan produces raw foreign-key values, and the FK-to-internal-ID mapping layer is not implemented. Scanning through the mis-wired vectors segfaulted. - ForeignRelTable::scanInternal now throws a clear RuntimeException instead of crashing. Queries handled by the foreign join push-down optimizer never reach this path. - CountRelTableOptimizer no longer rewrites count plans over scan-backed rel groups (RelTable::getNumTotalRows is a stub returning 0 for them, which silently produced wrong counts). - CountRelTable also guards ForeignRelTable at execution time as defense-in-depth.
…ling
ForeignRelTable::scanInternal: when the bound scan bind data carries
src/dst scan column positions (the csr_rel_* contract: foreign keys
usable as node offsets by design), wrap raw FK values into
internalID_t{offset=fkValue, tableID=nbrTableID} and emit rows through
the foreign scan, filtering by the current bound-node batch. Tables
without the contract keep failing fast.
Also fixes traversal routing for foreign attached databases:
- resolveTableStorage: fall through to main-path resolution for
non-LBUG attached DBs instead of throwing (shadow entries own ID
uniqueness; data lives in the foreign DB).
- ForeignJoinPushDownOptimizer: normalize rel foreignDatabaseName to
the "db(TYPE)" node-name format so the same-database pattern check
passes for both DDL-created ("db(TYPE)") and extension-registered
(raw) name shapes.
adsharma
force-pushed
the
foreign-rel-safety
branch
from
August 27, 2026 23:56
c462196 to
7995eb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segfault and a silent wrong-count found by the duckdb extension rel auto-detection tests (LadybugDB/extensions#65, duckdb_rel branch).
MATCHtraversal over a foreign-backed rel table (RelGroupCatalogEntrywith a scan function — the auto-detectedrel_*/csr_rel_*tables) cannot work yet: the extend pipeline expects lbug internal node IDs while the foreign scan produces raw foreign-key values, and the FK→internal-ID mapping layer is not implemented (tracked as deferred work for pg_client too). Scanning through the mis-wired vectors segfaulted.ForeignRelTable::scanInternalnow throws a clearRuntimeExceptioninstead. Queries rewritten by the foreign join push-down optimizer never reach this path.CountRelTableOptimizerno longer rewrites count plans over scan-backed rel groups:ForeignRelTable::getNumTotalRowsis a stub returning 0, which silently produced wrong counts.CountRelTableguardsForeignRelTableat execution time as defense-in-depth.Verified: duckdb_rel e2e cases pass; 249 tinysnb/multihop main tests pass.