fix(httpfs): make openFileWithImmutability available in WASM builds - #66
Closed
adsharma wants to merge 1 commit into
Closed
fix(httpfs): make openFileWithImmutability available in WASM builds#66adsharma wants to merge 1 commit into
adsharma wants to merge 1 commit into
Conversation
openFileWithImmutability() was declared under #if HTTPFS_REMOTE_READ_OPTIMIZATIONS, which is 0 for __WASM__ builds, but XetFileSystem::openFile calls it unconditionally. This broke the wasm build in the httpfs extension source target. Move the declaration into the always-compiled public section of HTTPFileSystem. The immutableContent flag remains a no-op in builds without remote read optimizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPFileSystem::openFileWithImmutability()was declared under#if HTTPFS_REMOTE_READ_OPTIMIZATIONS, which is0for__WASM__builds, butXetFileSystem::openFile(xetfs.cpp) calls it unconditionally. This broke the wasm build:HTTPFileSystem. The implementation in httpfs.cpp was never guarded, so only the declaration needed to move. TheimmutableContentflag remains a no-op in builds without remote read optimizations.Testing
Build and Deployworkflow with wasm only (all other targets skipped).