Configure Gradle daemon JVM toolchain - #2017
Conversation
04e90b8 to
ff94ee9
Compare
|
Updated the implementation after review of the maintenance workflow. The generated properties file is no longer the only change. The root Upgrade workflow, including a future move from JDK 21 to JDK 25:
The literal platform URLs in that file are generated task output, analogous to Gradle Wrapper metadata; they are not intended to be edited manually. This comment supersedes the original PR summary, which described the initial generated-file-only version of the change. |
7c64305 to
60b39ea
Compare
koperagen
added
the
infrastructure
| * Note, any version above 21 should work in theory, but JDK 21 is the only version we test with, | ||
| so it is the recommended version. | ||
| * The daemon JDK version is controlled by `gradle-jdk` in `gradle/libs.versions.toml`. | ||
| After changing it (for example, from `21` to `25`), run `./gradlew updateDaemonJvm` |
There was a problem hiding this comment.
could you mention this updateDaemonJvm task also in comments in the .toml file? Just so when we bump it there, we don't forget to run the task
| // To upgrade (for example, to JDK 25), change it in gradle/libs.versions.toml, run | ||
| // `./gradlew updateDaemonJvm`, and commit the regenerated gradle-daemon-jvm.properties file. | ||
| tasks.named<UpdateDaemonJvm>("updateDaemonJvm") { | ||
| languageVersion.set(libs.versions.gradle.jdk.map { JavaLanguageVersion.of(it) }) |
There was a problem hiding this comment.
could use languageVersion = , slightly cleaner :)
2 participants
Summary
gradle/gradle-daemon-jvm.propertiesfilegradle-jdkversionValidation
org.gradle.toolchains.foojay-resolver-convention1.0.0masterand changes only the generated daemon JVM properties fileFull build not run; this is a generated build-configuration-only change.
Closes #2016