Skip to content

fix(cloud-agent-next): isolate wrapper error parsing#3961

Merged
eshurakov merged 1 commit into
mainfrom
boulder-speaker
Jun 11, 2026
Merged

fix(cloud-agent-next): isolate wrapper error parsing#3961
eshurakov merged 1 commit into
mainfrom
boulder-speaker

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

Summary

  • Move wrapper-ready error parsing into the worker-side Kilo client boundary.
  • Keep the shared wrapper bootstrap module free of runtime worker-utils exports so the wrapper bundle does not pull in worker-only dependencies.
  • Preserve parser validation coverage in a focused unit test.

Verification

No manual verification was performed; this is a non-visual module-boundary change.

Visual Changes

N/A

Reviewer Notes

The wrapper bundle and Cloud Agent Next typecheck both complete successfully after separating the runtime parser.

@kilo-code-bot

kilo-code-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Clean module-boundary refactor: the runtime error parser is correctly isolated to the worker side (src/kilo/wrapper-ready-error.ts), keeping shared/wrapper-bootstrap.ts free of @kilocode/worker-utils runtime imports so the wrapper bundle stays lean. No logic changes — identical parser behaviour, validation coverage preserved in a focused unit test.

Files Reviewed (6 files)
  • services/cloud-agent-next/src/kilo/wrapper-ready-error.ts — new file, exact extraction of parser from shared module
  • services/cloud-agent-next/src/kilo/wrapper-ready-error.test.ts — new focused unit test, covers same cases as removed wrapper server.test.ts assertions
  • services/cloud-agent-next/src/kilo/wrapper-client.ts — import updated to new module, no logic change
  • services/cloud-agent-next/src/shared/wrapper-bootstrap.ts — runtime re-exports removed, only type WorkspaceFailureSubtype re-export kept; isRecord/hasString helpers remain for isWrapperSessionReadyRequest
  • services/cloud-agent-next/src/session/pending-messages.tsisWorkspaceFailureSubtype now imported directly from @kilocode/worker-utils/cloud-agent-failure
  • services/cloud-agent-next/src/telemetry/queue-reports.ts — same direct import update
  • services/cloud-agent-next/wrapper/src/server.test.ts — validation assertions removed (now covered by dedicated unit test)

Reviewed by claude-4.6-sonnet-20260217 · 1,021,929 tokens

Review guidance: REVIEW.md from base branch main

@eshurakov eshurakov merged commit 0150ed0 into main Jun 11, 2026
16 checks passed
@eshurakov eshurakov deleted the boulder-speaker branch June 11, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants