Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The docs said isbits element types get a random sentinel and that integer sentinels are random. The default is the all-ones bit pattern (-1 for signed integers, typemax for unsigned ones, a NaN for floats); a random sentinel is only chosen when setindex! stores the current one. Also fix the README's CI matrix and two typos. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SentinelArraydocstring and README say isbits element types get "a random/reasonable sentinel" and that integer sentinels are random. In fact the default sentinel is the value with all bits set:-1for signed integers,typemaxfor unsigned integers, a NaN for floats. A random sentinel is only picked whensetindex!stores the current one. This is the documentation half of #17, which was surprised thatSentinelArray([-1, -1, -1])is allmissing.value.typeof(value}typo and theBoolconstructor error message (Array{Union{Bool, Missing}}).Stacked on #122, which edits the same docstring; merge after it.
Verification: default sentinels and the
[missing, 2]example were checked on Julia 1.12.6; full suite passes on this branch.🤖 Generated with Claude Code