Repository navigation
Encode non-ASCII host names with IDNA before resolving - #2105
Merged
Merged
Conversation
slozier
approved these changes
Oct 21, 2026
slozier
left a comment
slozier
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
test_idna. The IronPython test wrapper expected it to fail on Linux and fail on macOS. But the success/failure depends on the DNS resolver used and its capability, not the OS per se.CPython encodes host names with the "idna" codec before passing them to the resolver. IronPython passed them to Dns as-is, which works on Windows but on POSIX sends raw UTF-8 to
getaddrinfo, so the lookup usually (but not always) fails.test_idnaonly passed on macOS CI because the runner's resolver happens to accept such names. This change adapts CPython's behaviour.