Skip to content

feat: support volumeGroupSnapshot - #65

Merged
MahanteshR12 merged 11 commits into
IBM:masterfrom
MahanteshR12:feat-vgs
Nov 6, 2026
Merged

MahanteshR12 merged 11 commits into
IBM:masterfrom
MahanteshR12:feat-vgs

Conversation

@MahanteshR12

Copy link
Copy Markdown
Contributor

Description:
VolumeGroupSnapshots as a new feature will supported in IBM VPC Block CSI driver and as part of that the interfaces, data_types and methods have been added.

@MahanteshR12
MahanteshR12 force-pushed the feat-vgs branch 3 times, most recently from 0035e3a to dbe739a Compare September 28, 2026 08:51
- Add VolumeGroupSnapshot support to provider interfaces
- Add GetShareSnapshot and GetShareSnapshotByName methods
- Add group snapshot manager interface and fakes
- Add unit tests for group snapshot operations
- Upgrade Go and lint tooling
- Add GitHub Actions pipeline workflow

Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
…ling)

Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Regenerated via 'go generate ./lib/provider/...' to incorporate
ModifyVolume (from master) and GroupSnapshot methods into correct
alphabetical order as produced by counterfeiter.

Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>

@arahamad arahamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check my review comments

Comment thread lib/provider/data_types.go Resolved
Comment thread lib/provider/data_types.go Resolved
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>

@arahamad arahamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prankulmahajan prankulmahajan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MahanteshR12
MahanteshR12 merged commit a3cbf6d into IBM:master Nov 6, 2026
2 checks passed
@MahanteshR12
MahanteshR12 deleted the feat-vgs branch November 6, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants