Repository navigation
feat: support volumeGroupSnapshot - #65
Merged
Merged
Conversation
MahanteshR12
force-pushed
the
feat-vgs
branch
3 times, most recently
from
September 28, 2026 08:51
0035e3a to
dbe739a
Compare
- Add VolumeGroupSnapshot support to provider interfaces - Add GetShareSnapshot and GetShareSnapshotByName methods - Add group snapshot manager interface and fakes - Add unit tests for group snapshot operations - Upgrade Go and lint tooling - Add GitHub Actions pipeline workflow Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
MahanteshR12
force-pushed
the
feat-vgs
branch
from
September 28, 2026 08:54
dbe739a to
ae334f8
Compare
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
MahanteshR12
force-pushed
the
feat-vgs
branch
from
October 28, 2026 10:02
9b2ed1d to
696750f
Compare
…ling) Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
MahanteshR12
force-pushed
the
feat-vgs
branch
from
October 28, 2026 10:08
696750f to
3f1bf66
Compare
Regenerated via 'go generate ./lib/provider/...' to incorporate ModifyVolume (from master) and GroupSnapshot methods into correct alphabetical order as produced by counterfeiter. Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
arahamad
requested changes
Nov 2, 2026
arahamad
left a comment
Collaborator
There was a problem hiding this comment.
Can you please check my review comments
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
Signed-off-by: Mahantesh-R <mahantesh.r@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
VolumeGroupSnapshots as a new feature will supported in IBM VPC Block CSI driver and as part of that the interfaces, data_types and methods have been added.