Skip to content

fix(git): support SSH git@ style URLs and fix tag checkout issues (issues #170, #129)#251

Open
isaquepinheiro wants to merge 1 commit into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-170-ssh-parsing
Open

fix(git): support SSH git@ style URLs and fix tag checkout issues (issues #170, #129)#251
isaquepinheiro wants to merge 1 commit into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-170-ssh-parsing

Conversation

@isaquepinheiro

Copy link
Copy Markdown

This PR enhances the Git remote URL parsing regex to support standard SSH git@github.com style paths and resolves conflicts with version tag parsing during SSH checkouts.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0f2a917). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/core/domain/dependency.go 0.00% 1 Missing and 1 partial ⚠️
internal/core/services/installer/utils.go 92.85% 1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage        ?   25.87%           
=======================================
  Files           ?       82           
  Lines           ?     3842           
  Branches        ?        0           
=======================================
  Hits            ?      994           
  Misses          ?     2772           
  Partials        ?       76           
Flag Coverage Δ
unittests 25.87% <86.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants