[Chore] 将YggdrasilSession转换为记录类#6360
Closed
ToobLac wants to merge 1 commit into
Closed
Conversation
Member
|
这些 PR 都只是机械的把类转换成 record 吗？单纯这样的转换我觉得没有意义。 我认为这些重构，要么是在重构相关代码时顺便进行，要么是作为对类现代化改造的一部分进行，在改写为 record 的同时对这些类字段的可空性、不可变性进行思考和标注，并且补齐文档。这样批量化机械重构我认为完全没有正面价值，既引入了风险，又没有明显提升可读性和可维护性，我想把它们都关掉。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.