Skip to content

Figure.pygmtlogo: Extend the region to get rid of the 'no_clip' parameter#4687

Merged
seisman merged 1 commit into
pygmtlogofrom
pygmtlogo-noclip
Jun 24, 2026
Merged

Figure.pygmtlogo: Extend the region to get rid of the 'no_clip' parameter#4687
seisman merged 1 commit into
pygmtlogofrom
pygmtlogo-noclip

Conversation

@seisman

@seisman seisman commented Jun 21, 2026

Copy link
Copy Markdown
Member

Extending the region parameter by 20% so that we no longer need the no_clip parameter when plotting hexagonal logos and wordmarks.

Changes this PR don't affect the logo appearance, but affect the debugging basemap in the tests for logo designs.

@seisman seisman added this to the 0.19.0 milestone Jun 21, 2026
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jun 21, 2026
@seisman seisman marked this pull request as ready for review June 21, 2026 03:06
@seisman seisman requested a review from yvonnefroehlich June 21, 2026 03:06
@github-actions

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_pygmtlogo_design_circle-horizontal.png
modified pygmt/tests/baseline/test_pygmtlogo_design_circle-vertical.png
modified pygmt/tests/baseline/test_pygmtlogo_design_hexagon-horizontal.png
modified pygmt/tests/baseline/test_pygmtlogo_design_hexagon-vertical.png
modified pygmt/tests/baseline/test_pygmtlogo_wordmark_vertical_circle.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_pygmtlogo_design_circle-horizontal.png
test_pygmtlogo_design_circle-vertical.png
test_pygmtlogo_design_hexagon-horizontal.png
test_pygmtlogo_design_hexagon-vertical.png
test_pygmtlogo_wordmark_vertical_circle.png

Report last updated at commit f8d2a9c

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Jun 22, 2026
@seisman seisman merged commit 3e00ddd into pygmtlogo Jun 24, 2026
26 of 30 checks passed
@seisman seisman deleted the pygmtlogo-noclip branch June 24, 2026 01:06

@yvonnefroehlich yvonnefroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants