Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, I had a go at de-obfuscating the code. I didn't completely finish, but I got far enough that I could see how to make the player a bit more accessible.
Now, when using a screen reader, the playheads are somewhat accessible. Playback can be started and stopped using the "press" action of a screen reader. I have not implemented key handling, but doing so would be fairly trivial.
I also added an optional
data-attribute to the API:data-title. This is used as part of the accessible label of the playhead.Obviously, this isn't worth merging, but I hope it serves as some kind of inspiration for how this great player can be made more accessible!