Repository navigation
Make daemon_controller's socket ping confirm the connection - #24
Merged
Merged
Conversation
On 2026-11-01 warp macOS CI runners, a non-blocking connect to a closed loopback TCP port completes without an error, even though the socket never becomes connected (after connecting getpeername fails with EINVAL). ping_socket took that as "something is listening", so closed ports looked open. This broke passenger macOS Nginx integration tests: NginxController#stop waits until the test port stops answering, which never happened, so each test group timed out after 30 seconds. Added diagnostics confirmed that no process was listening on that port and ports that nothing was using behaved the same way. The same ping is used to decide when Passenger Standalone considers its server started. ping_socket now asks for the peer address before reporting success, and treats ENOTCONN or EINVAL as "not listening". Signed-off-by: Camden Narzt <6243207+CamJN@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 2026-11-01 warp macOS CI runners, a non-blocking connect to a closed loopback TCP port completes without an error, even though the socket never becomes connected (after connecting getpeername fails with EINVAL). ping_socket took that as "something is listening", so closed ports looked open.
This broke passenger macOS Nginx integration tests: NginxController#stop waits until the test port stops answering, which never happened, so each test group timed out after 30 seconds. Added diagnostics confirmed that no process was listening on that port and ports that nothing was using behaved the same way. The same ping is used to decide when Passenger Standalone considers its server started.
ping_socket now asks for the peer address before reporting success, and treats ENOTCONN or EINVAL as "not listening".