Skip to content

starred playlist support#30

Open
LinusU wants to merge 1 commit into
Floby:masterfrom
LinusU:patch-3
Open

starred playlist support#30
LinusU wants to merge 1 commit into
Floby:masterfrom
LinusU:patch-3

Conversation

@LinusU

@LinusU LinusU commented Sep 26, 2013

Copy link
Copy Markdown
Contributor

Support for getting the special "starred" playlist, session.getStarred().

@LinusU

LinusU commented Sep 26, 2013

Copy link
Copy Markdown
Contributor Author

Just saw that you made some slight refactoring to the tests, will updated and push within 5 minutes :)

@LinusU

LinusU commented Sep 26, 2013

Copy link
Copy Markdown
Contributor Author

Oh fuck, I really screwed this up, will try to rebase on your master...

@LinusU

LinusU commented Sep 26, 2013

Copy link
Copy Markdown
Contributor Author

Success! I've run all the tests locally and it should be good to merge.

@Floby

Floby commented Sep 26, 2013

Copy link
Copy Markdown
Owner

Looks good to me.
I'm wondering if it's a good testing practice to assume the currently logged in user will have starred at least one track.

@LinusU

LinusU commented Sep 26, 2013

Copy link
Copy Markdown
Contributor Author

True, do you want me to remove that line?

@Floby

Floby commented Sep 26, 2013

Copy link
Copy Markdown
Owner

No, that's a good test. Maybe we should star a track before that.

On 26 September 2013 11:33, Linus Unnebäck notifications@github.com wrote:

True, do you want me to remove that line?


Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-25154573
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants