Repository navigation
Conversation
Author
|
Friendly bump on this. Glad to adjust if anything needs changing. |
khvn26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123.
Add Unwrap to both error types and retain the API error in the public flag methods, so errors.Is and errors.As can reach the underlying request error. Existing messages and response fields stay unchanged.
Tests cover canceled and expired contexts through environment and identity methods, plus API errors with and without a cause. The regressions fail on main and pass with this change.
Passed locally on Go 1.26.6: full race suite, tagged suite, build, vet and golangci-lint 2.13.1.