Repository navigation
Avoid tiny segment counts right after the segment length doubles - #78
Merged
Merged
Conversation
#77) Just after binary_fuse_calculate_segment_length doubles the segment length, the filter could end up with very few segments (e.g. 12 segments of 1024 for 11.5k keys). Such a graph is close to a plain 3-wise XOR graph and the load was too near the peeling threshold: binary_fuse*_populate failed for 20-40% of random key sets around size 11,500 and ~3% around 12,350, with smaller but non-negligible failure rates after every doubling below ~40k keys. Halve the segment length until there are at least 32 segments (keeping segments >= 256). This only changes layouts for roughly 3.4k..58k keys, uses slightly less memory, and leaves construction and query speed unchanged. Add a regression test at the affected sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for #77 reported by @manishrjain